Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1569)

Unified Diff: runtime/vm/intermediate_language.h

Issue 12042014: Revert "Introduce InvokeMathCFunction that can be used to directly invoke mathematical function pro… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/il_printer.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
diff --git a/runtime/vm/intermediate_language.h b/runtime/vm/intermediate_language.h
index a572b33874899ec8cae06c9a9b39343b16ac2e33..0228cfb5fef05827f060d3d051666f028b314636 100644
--- a/runtime/vm/intermediate_language.h
+++ b/runtime/vm/intermediate_language.h
@@ -48,7 +48,6 @@ class FlowGraphOptimizer;
V(_Double, round, DoubleRound, 620870996) \
V(_Double, floor, DoubleFloor, 620870996) \
V(_Double, ceil, DoubleCeil, 620870996) \
- V(_Double, pow, DoublePow, 1131958048) \
V(::, sqrt, MathSqrt, 1662640002) \
// Class that recognizes the name and owner of a function and returns the
@@ -275,8 +274,7 @@ class EmbeddedArray<T, 0> {
M(UnaryMintOp) \
M(CheckArrayBound) \
M(Constraint) \
- M(StringFromCharCode) \
- M(InvokeMathCFunction) \
+ M(StringFromCharCode)
#define FORWARD_DECLARATION(type) class type##Instr;
@@ -517,7 +515,6 @@ FOR_EACH_INSTRUCTION(INSTRUCTION_TYPE_CHECK)
friend class LICM;
friend class DoubleToSmiInstr;
friend class DoubleToDoubleInstr;
- friend class InvokeMathCFunctionInstr;
intptr_t deopt_id_;
intptr_t lifetime_position_; // Position used by register allocator.
@@ -4059,76 +4056,6 @@ class DoubleToDoubleInstr : public TemplateDefinition<1> {
};
-class InvokeMathCFunctionInstr : public Definition {
- public:
- InvokeMathCFunctionInstr(ZoneGrowableArray<Value*>* inputs,
- InstanceCallInstr* instance_call,
- MethodRecognizer::Kind recognized_kind)
- : inputs_(inputs), locs_(NULL), recognized_kind_(recognized_kind) {
- ASSERT(inputs_->length() == ArgumentCountFor(recognized_kind_));
- deopt_id_ = instance_call->deopt_id();
- }
-
- static intptr_t ArgumentCountFor(MethodRecognizer::Kind recognized_kind_);
-
- const RuntimeEntry& TargetFunction() const;
-
- MethodRecognizer::Kind recognized_kind() const { return recognized_kind_; }
-
- DECLARE_INSTRUCTION(InvokeMathCFunction)
- virtual RawAbstractType* CompileType() const;
- virtual void PrintOperandsTo(BufferFormatter* f) const;
-
- virtual bool CanDeoptimize() const { return false; }
-
- virtual bool HasSideEffect() const { return false; }
-
- virtual intptr_t ResultCid() const { return kDoubleCid; }
-
- virtual Representation representation() const {
- return kUnboxedDouble;
- }
-
- virtual Representation RequiredInputRepresentation(intptr_t idx) const {
- ASSERT((0 <= idx) && (idx < InputCount()));
- return kUnboxedDouble;
- }
-
- virtual intptr_t DeoptimizationTarget() const { return deopt_id_; }
-
- virtual intptr_t InputCount() const {
- return inputs_->length();
- }
-
- virtual Value* InputAt(intptr_t i) const {
- return (*inputs_)[i];
- }
-
- virtual void SetInputAt(intptr_t i, Value* value) {
- ASSERT(value != NULL);
- (*inputs_)[i] = value;
- }
-
- // Returns a structure describing the location constraints required
- // to emit native code for this definition.
- LocationSummary* locs() {
- if (locs_ == NULL) {
- locs_ = MakeLocationSummary();
- }
- return locs_;
- }
-
- private:
- ZoneGrowableArray<Value*>* inputs_;
-
- LocationSummary* locs_;
-
- const MethodRecognizer::Kind recognized_kind_;
-
- DISALLOW_COPY_AND_ASSIGN(InvokeMathCFunctionInstr);
-};
-
-
class CheckClassInstr : public TemplateInstruction<1> {
public:
CheckClassInstr(Value* value,
« no previous file with comments | « runtime/vm/il_printer.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698