Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 12042014: Revert "Introduce InvokeMathCFunction that can be used to directly invoke mathematical function pro… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/locations.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_x64.cc
diff --git a/runtime/vm/intermediate_language_x64.cc b/runtime/vm/intermediate_language_x64.cc
index bf7cb827706b97068cc1e39ad7a36baeeaf13580..5a92da3aad2895a078ef9ad5a8ba04c4798bf70c 100644
--- a/runtime/vm/intermediate_language_x64.cc
+++ b/runtime/vm/intermediate_language_x64.cc
@@ -2402,40 +2402,6 @@ void DoubleToDoubleInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
}
-LocationSummary* InvokeMathCFunctionInstr::MakeLocationSummary() const {
- // Calling convention on x64 uses XMM0 and XMM1 to pass the first two
- // double arguments and XMM0 to return the result. Unfortunately
- // currently we can't specify these registers because ParallelMoveResolver
- // assumes that XMM0 is free at all times.
- // TODO(vegorov): allow XMM0 to be used.
- ASSERT((InputCount() == 1) || (InputCount() == 2));
- const intptr_t kNumTemps = 0;
- LocationSummary* result =
- new LocationSummary(InputCount(), kNumTemps, LocationSummary::kCall);
- result->set_in(0, Location::FpuRegisterLocation(XMM1, Location::kDouble));
- if (InputCount() == 2) {
- result->set_in(1, Location::FpuRegisterLocation(XMM2, Location::kDouble));
- }
- result->set_out(Location::FpuRegisterLocation(XMM1, Location::kDouble));
- return result;
-}
-
-
-void InvokeMathCFunctionInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
- ASSERT(locs()->in(0).fpu_reg() == XMM1);
- __ enter(Immediate(0));
- __ ReserveAlignedFrameSpace(kDoubleSize * InputCount());
- __ movaps(XMM0, locs()->in(0).fpu_reg());
- if (InputCount() == 2) {
- ASSERT(locs()->in(1).fpu_reg() == XMM2);
- __ movaps(XMM1, locs()->in(1).fpu_reg());
- }
- __ CallRuntime(TargetFunction());
- __ movaps(locs()->out().fpu_reg(), XMM0);
- __ leave();
-}
-
-
LocationSummary* PolymorphicInstanceCallInstr::MakeLocationSummary() const {
return MakeCallSummary();
}
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/locations.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698