chrome/browser/ui/cocoa/location_bar/web_intents_button_decoration.mm - Issue 12042002: Alternate NTP: Add search token to omnibox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/web_intents_button_decoration.mm

Issue 12042002: Alternate NTP: Add search token to omnibox (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address review comments Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/location_bar/separator_decoration.mm ('K') | « chrome/browser/ui/cocoa/location_bar/separator_decoration_unittest.mm ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/web_intents_button_decoration.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/web_intents_button_decoration.mm b/chrome/browser/ui/cocoa/location_bar/web_intents_button_decoration.mm

index 5551c6e7b29d019017202fd2ab8f114c85c18683..ed22c3f61ed1e0774260636eb6c6dc438a9341cb 100644

--- a/chrome/browser/ui/cocoa/location_bar/web_intents_button_decoration.mm

+++ b/chrome/browser/ui/cocoa/location_bar/web_intents_button_decoration.mm

@@ -27,7 +27,6 @@ const NSTimeInterval kAnimationIntervalS = 1.0 / 60.0;

const CGFloat kTextMarginPadding = 4;

const CGFloat kIconMarginPadding = 2;

const CGFloat kBorderPadding = 3;

-const CGFloat kBubbleYInset = 4.0;

// During animation, the text opens to full width.

enum AnimationState {

@@ -187,7 +186,7 @@ void WebIntentsButtonDecoration::DrawInFrame(NSRect frame,

return;

}

- frame = NSInsetRect(frame, 0.0, kBubbleYInset);

+ frame = NSInsetRect(frame, 0.0, kTextYInset);

NSDrawThreePartImage(frame,

left_image_.get(),

center_image_.get(),