Alternate NTP: Add search token to omnibox

chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/memory/scoped_nsobject.h"
 #include "base/utf_string_conversions.h"
 #import "chrome/browser/ui/cocoa/cocoa_test_helper.h"
 #import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h"
 #import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h"
 #import "chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.h"
 #import "chrome/browser/ui/cocoa/location_bar/keyword_hint_decoration.h"
 #import "chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h"
 #import "chrome/browser/ui/cocoa/location_bar/location_icon_decoration.h"
 #import "chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.h"
+#import "chrome/browser/ui/cocoa/location_bar/separator_decoration.h"
 #import "chrome/browser/ui/cocoa/location_bar/star_decoration.h"
 #include "grit/theme_resources.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/platform_test.h"
 #include "third_party/ocmock/gtest_support.h"
 #import "third_party/ocmock/OCMock/OCMock.h"
 #include "ui/base/resource/resource_bundle.h"
 
 using ::testing::Return;
 using ::testing::StrictMock;
 using ::testing::_;
 
 namespace {
 
 // Width of the field so that we don't have to ask |field_| for it all
 // the time.
 const CGFloat kWidth(300.0);
 
 // A narrow width for tests which test things that don't fit.
 const CGFloat kNarrowWidth(5.0);
 
 class MockDecoration : public LocationBarDecoration {
  public:
-  virtual CGFloat GetWidthForSpace(CGFloat width) { return 20.0; }
+  MockDecoration() : LocationBarDecoration(),
+                     should_auto_collapse_(false) {
+  }
+
+  virtual CGFloat GetWidthForSpace(CGFloat width, CGFloat text_width) {
+    CGFloat my_width = 20.0;

[Scott Hess - ex-Googler, 2013/01/29 23:28:37]

Make it a real constant, then.

[sail, 2013/01/30 01:40:56]

Done.

+    if (should_auto_collapse_ && (width - my_width) < text_width)
+      return kOmittedWidth;
+    return my_width;
+  }
+
+  void set_should_auto_collapse(bool value) { should_auto_collapse_ = value; }
 
   MOCK_METHOD2(DrawInFrame, void(NSRect frame, NSView* control_view));
   MOCK_METHOD0(GetToolTip, NSString*());
+
+ private:
+  bool should_auto_collapse_;
 };
 
 class AutocompleteTextFieldCellTest : public CocoaTest {
  public:
   AutocompleteTextFieldCellTest() {
     // Make sure this is wide enough to play games with the cell
     // decorations.
     const NSRect frame = NSMakeRect(0, 0, kWidth, 30);
 
     scoped_nsobject<NSTextField> view(
@@ skipping 43 matching lines @@
 
   // Load available decorations and try drawing.  To make sure that
   // they are actually drawn, check that |GetWidthForSpace()| doesn't
   // indicate that they should be omitted.
   const CGFloat kVeryWide = 1000.0;
 
   SelectedKeywordDecoration selected_keyword_decoration([view_ font]);
   selected_keyword_decoration.SetVisible(true);
   selected_keyword_decoration.SetKeyword(ASCIIToUTF16("Google"), false);
   [cell addLeftDecoration:&selected_keyword_decoration];
-  EXPECT_NE(selected_keyword_decoration.GetWidthForSpace(kVeryWide),
+  EXPECT_NE(selected_keyword_decoration.GetWidthForSpace(kVeryWide, 0),
             LocationBarDecoration::kOmittedWidth);
 
   // TODO(shess): This really wants a |LocationBarViewMac|, but only a
   // few methods reference it, so this works well enough.  But
   // something better would be nice.
   LocationIconDecoration location_icon_decoration(NULL);
   location_icon_decoration.SetVisible(true);
   location_icon_decoration.SetImage([NSImage imageNamed:@"NSApplicationIcon"]);
   [cell addLeftDecoration:&location_icon_decoration];
-  EXPECT_NE(location_icon_decoration.GetWidthForSpace(kVeryWide),
+  EXPECT_NE(location_icon_decoration.GetWidthForSpace(kVeryWide, 0),
             LocationBarDecoration::kOmittedWidth);
 
   EVBubbleDecoration ev_bubble_decoration(&location_icon_decoration,
                                           [view_ font]);
   ev_bubble_decoration.SetVisible(true);
   ev_bubble_decoration.SetImage([NSImage imageNamed:@"NSApplicationIcon"]);
   ev_bubble_decoration.SetLabel(@"Application");
   [cell addLeftDecoration:&ev_bubble_decoration];
-  EXPECT_NE(ev_bubble_decoration.GetWidthForSpace(kVeryWide),
+  EXPECT_NE(ev_bubble_decoration.GetWidthForSpace(kVeryWide, 0),
             LocationBarDecoration::kOmittedWidth);
 
   StarDecoration star_decoration(NULL);
   star_decoration.SetVisible(true);
   [cell addRightDecoration:&star_decoration];
-  EXPECT_NE(star_decoration.GetWidthForSpace(kVeryWide),
+  EXPECT_NE(star_decoration.GetWidthForSpace(kVeryWide, 0),
             LocationBarDecoration::kOmittedWidth);
 
   KeywordHintDecoration keyword_hint_decoration([view_ font]);
   keyword_hint_decoration.SetVisible(true);
   keyword_hint_decoration.SetKeyword(ASCIIToUTF16("google"), false);
   [cell addRightDecoration:&keyword_hint_decoration];
-  EXPECT_NE(keyword_hint_decoration.GetWidthForSpace(kVeryWide),
+  EXPECT_NE(keyword_hint_decoration.GetWidthForSpace(kVeryWide, 0),
             LocationBarDecoration::kOmittedWidth);
 
   // Make sure we're actually calling |DrawInFrame()|.
   StrictMock<MockDecoration> mock_decoration;
   mock_decoration.SetVisible(true);
   [cell addLeftDecoration:&mock_decoration];
   EXPECT_CALL(mock_decoration, DrawInFrame(_, _));
-  EXPECT_NE(mock_decoration.GetWidthForSpace(kVeryWide),
+  EXPECT_NE(mock_decoration.GetWidthForSpace(kVeryWide, 0),
             LocationBarDecoration::kOmittedWidth);
 
   [view_ display];
 
   [cell clearDecorations];
 }
 
 TEST_F(AutocompleteTextFieldCellTest, TextFrame) {
   AutocompleteTextFieldCell* cell =
       static_cast<AutocompleteTextFieldCell*>([view_ cell]);
@@ skipping 133 matching lines @@
 
   // |controlView| gets the tooltip for the left decoration.
   id controlView = [OCMockObject mockForClass:[AutocompleteTextField class]];
   [[controlView expect] addToolTip:tooltip forRect:leftDecorationRect];
 
   [cell updateToolTipsInRect:bounds ofView:controlView];
 
   EXPECT_OCMOCK_VERIFY(controlView);
 }
 
+TEST_F(AutocompleteTextFieldCellTest, HideUnneededSeparators) {
+  AutocompleteTextFieldCell* cell =
+      static_cast<AutocompleteTextFieldCell*>([view_ cell]);
+  const NSRect bounds = [view_ bounds];
+
+  SeparatorDecoration separator;
+  [cell clearDecorations];
+  [cell addRightDecoration:&mock_right_decoration0_];
+  [cell addRightDecoration:&separator];
+  [cell addRightDecoration:&mock_right_decoration1_];
+  separator.SetVisible(true);
+
+  // Verify that a separator between two decorations is visible.
+  mock_right_decoration0_.SetVisible(true);
+  mock_right_decoration1_.SetVisible(true);
+  NSRect rect = [cell frameForDecoration:&separator inFrame:bounds];
+  EXPECT_LT(0, NSWidth(rect));
+
+  // Verify that a separator with no visible decorations on the right is hidden.
+  mock_right_decoration0_.SetVisible(false);
+  mock_right_decoration1_.SetVisible(true);
+  rect = [cell frameForDecoration:&separator inFrame:bounds];
+  EXPECT_EQ(0, NSWidth(rect));
+
+  // Verify that a separator with no visible decorations on the left is hidden.
+  mock_right_decoration0_.SetVisible(true);
+  mock_right_decoration1_.SetVisible(false);
+  rect = [cell frameForDecoration:&separator inFrame:bounds];
+  EXPECT_EQ(0, NSWidth(rect));
+}
+
+TEST_F(AutocompleteTextFieldCellTest, AutoCollapse) {
+  AutocompleteTextFieldCell* cell =
+      static_cast<AutocompleteTextFieldCell*>([view_ cell]);
+  const NSRect bounds = [view_ bounds];
+  // Force the string to overlap decorations.
+  [cell setStringValue:@"WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW"];
+
+  // Verify that the decoration is visible without auto collapse.
+  mock_right_decoration0_.SetVisible(true);
+  mock_right_decoration0_.set_should_auto_collapse(false);
+  NSRect rect = [cell frameForDecoration:&mock_right_decoration0_
+                                 inFrame:bounds];
+  EXPECT_LT(0, NSWidth(rect));
+
+  // Verify that the decoration is hidden with auto collapse.
+  mock_right_decoration0_.set_should_auto_collapse(true);
+  rect = [cell frameForDecoration:&mock_right_decoration0_
+                          inFrame:bounds];
+  EXPECT_EQ(0, NSWidth(rect));
+
+  // Verify that the decoration is visible with auto collapse and short string.
+  [cell setStringValue:@"WWW"];
+  rect = [cell frameForDecoration:&mock_right_decoration0_
+                                 inFrame:bounds];

[Scott Hess - ex-Googler, 2013/01/29 23:28:37]

Alignment.

[sail, 2013/01/30 01:40:56]

Done.

+  EXPECT_LT(0, NSWidth(rect));
+}
+
 }  // namespace