Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(88)

Issue 1204163002: New SELECT Popup: Delay to create internal OPTION elements if there are many items. (Closed)

Created:
4 years, 10 months ago by tkent
Modified:
4 years, 10 months ago
Reviewers:
keishi
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

New SELECT Popup: Delay to create internal OPTION elements if there are many items. If the number of items is larger than ListPicker.DelayedLayoutThreshold(1000), creates OPTION elements only for the first ListPicker.DelayedLayoutThreshold items or this._config.selectedIndex before the first layout, then creates remaining OPTIONs later. Because it's possible that the popup width is shorter than the widest item, we apply white-space:pre-wrap to OPTIONs in this case. BUG=500401 R=keishi@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197800

Patch Set 1 #

Total comments: 2

Patch Set 2 : lower CSS class #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -5 lines) Patch
M Source/web/resources/listPicker.css View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/web/resources/listPicker.js View 1 4 chunks +40 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tkent
Keishi, please review this.
4 years, 10 months ago (2015-06-25 04:13:04 UTC) #2
keishi
LGTM https://codereview.chromium.org/1204163002/diff/1/Source/web/resources/listPicker.css File Source/web/resources/listPicker.css (right): https://codereview.chromium.org/1204163002/diff/1/Source/web/resources/listPicker.css#newcode16 Source/web/resources/listPicker.css:16: .WRAP option { nite: do we want to ...
4 years, 10 months ago (2015-06-25 04:38:00 UTC) #3
tkent
https://codereview.chromium.org/1204163002/diff/1/Source/web/resources/listPicker.css File Source/web/resources/listPicker.css (right): https://codereview.chromium.org/1204163002/diff/1/Source/web/resources/listPicker.css#newcode16 Source/web/resources/listPicker.css:16: .WRAP option { On 2015/06/25 04:37:59, keishi wrote: > ...
4 years, 10 months ago (2015-06-25 05:57:26 UTC) #4
tkent
4 years, 10 months ago (2015-06-25 07:04:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 197800 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698