Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1204153002: Add samplingTime mode to nanobench (Closed)

Created:
5 years, 6 months ago by Chris Dalton
Modified:
5 years, 6 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@upload_loopSKP
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add samplingTime mode to nanobench Adds a nanobench mode that takes samples for a fixed amount of time, rather than taking a fixed amount of samples. BUG=skia: Committed: https://skia.googlesource.com/skia/+/e1b8958877a512bf83cbc2c72bb31e7d71b06f43

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : comments #

Total comments: 1

Patch Set 4 : Fix windows #

Patch Set 5 : copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -25 lines) Patch
M bench/nanobench.cpp View 1 2 3 12 chunks +60 lines, -22 lines 0 comments Download
M tools/Stats.h View 1 2 3 4 3 chunks +15 lines, -2 lines 0 comments Download
M tools/VisualBench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (8 generated)
Chris Dalton
5 years, 6 months ago (2015-06-25 03:38:13 UTC) #2
mtklein
Seems like a good idea to me. https://codereview.chromium.org/1204153002/diff/20001/bench/nanobench.cpp File bench/nanobench.cpp (right): https://codereview.chromium.org/1204153002/diff/20001/bench/nanobench.cpp#newcode1056 bench/nanobench.cpp:1056: double endTime ...
5 years, 6 months ago (2015-06-25 12:06:46 UTC) #3
Chris Dalton
https://codereview.chromium.org/1204153002/diff/20001/bench/nanobench.cpp File bench/nanobench.cpp (right): https://codereview.chromium.org/1204153002/diff/20001/bench/nanobench.cpp#newcode1056 bench/nanobench.cpp:1056: double endTime = GetTimeMs() + samplingTimeMs; On 2015/06/25 12:06:46, ...
5 years, 6 months ago (2015-06-25 19:45:18 UTC) #4
mtklein
lgtm https://codereview.chromium.org/1204153002/diff/40001/bench/nanobench.cpp File bench/nanobench.cpp (right): https://codereview.chromium.org/1204153002/diff/40001/bench/nanobench.cpp#newcode1064 bench/nanobench.cpp:1064: timer.end(); Yeah, .end() is probably a bit of ...
5 years, 6 months ago (2015-06-25 19:53:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204153002/40001
5 years, 6 months ago (2015-06-25 19:54:10 UTC) #7
commit-bot: I haz the power
The author cdalton@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 6 months ago (2015-06-25 19:54:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/725)
5 years, 6 months ago (2015-06-25 19:55:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204153002/60001
5 years, 6 months ago (2015-06-25 21:00:29 UTC) #13
commit-bot: I haz the power
The author cdalton@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 6 months ago (2015-06-25 21:00:30 UTC) #14
commit-bot: I haz the power
The author cdalton@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 6 months ago (2015-06-25 21:01:30 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/730)
5 years, 6 months ago (2015-06-25 21:01:32 UTC) #17
Chris Dalton
>> "tools/Stats.h is missing a correct copyright header." Should I just add one?
5 years, 6 months ago (2015-06-25 21:03:04 UTC) #18
Chris Dalton
Added copyright to tools/Stats.h
5 years, 6 months ago (2015-06-25 21:05:18 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204153002/80001
5 years, 6 months ago (2015-06-26 02:11:00 UTC) #22
commit-bot: I haz the power
The author cdalton@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 6 months ago (2015-06-26 02:11:01 UTC) #23
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 02:17:13 UTC) #24
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/e1b8958877a512bf83cbc2c72bb31e7d71b06f43

Powered by Google App Engine
This is Rietveld 408576698