Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1204123003: Reland Extend big-disjunction optimization to case-independent regexps (Closed)

Created:
5 years, 6 months ago by Erik Corry Chromium.org
Modified:
5 years, 6 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland Extend big-disjunction optimization to case-independent regexps Previous code review https://codereview.chromium.org/1182783009/ R=yangguo@chromium.org BUG=chromium:482998 LOG=n Committed: https://crrev.com/daef0ec5f4ce4ad6f4739339f27cfcbf6d30d5f0 Cr-Commit-Position: refs/heads/master@{#29290}

Patch Set 1 #

Patch Set 2 : Skip slow architecture-independent tests on slower CPUs and simulators #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -37 lines) Patch
M src/heap-snapshot-generator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/jsregexp.cc View 5 chunks +56 lines, -9 lines 0 comments Download
M src/list.h View 1 chunk +8 lines, -5 lines 0 comments Download
M src/list-inl.h View 2 chunks +9 lines, -6 lines 0 comments Download
M src/vector.h View 2 chunks +17 lines, -10 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +3 lines, -2 lines 0 comments Download
A test/mjsunit/regexp-sort.js View 1 chunk +48 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-482998.js View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Erik Corry Chromium.org
5 years, 6 months ago (2015-06-25 11:07:26 UTC) #1
Yang
On 2015/06/25 11:07:26, Erik Corry Chromium.org wrote: lgtm.
5 years, 6 months ago (2015-06-25 11:10:46 UTC) #2
Yang
On 2015/06/25 11:07:26, Erik Corry Chromium.org wrote: lgtm.
5 years, 6 months ago (2015-06-25 11:10:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204123003/20001
5 years, 6 months ago (2015-06-25 11:11:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204123003/20001
5 years, 6 months ago (2015-06-25 11:40:32 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-25 11:42:10 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 11:42:32 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/daef0ec5f4ce4ad6f4739339f27cfcbf6d30d5f0
Cr-Commit-Position: refs/heads/master@{#29290}

Powered by Google App Engine
This is Rietveld 408576698