Fix menu corners: the menu background was being painted as a rect when in fact,

ui/views/controls/menu/menu_scroll_view_container.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/menu/menu_scroll_view_container.h"
 
 #include "third_party/skia/include/core/SkPaint.h"
 #include "third_party/skia/include/core/SkPath.h"
 #include "ui/base/accessibility/accessible_view_state.h"
 #include "ui/gfx/canvas.h"
 #include "ui/native_theme/native_theme.h"
 #include "ui/views/border.h"
 #include "ui/views/controls/menu/menu_config.h"
 #include "ui/views/controls/menu/menu_controller.h"
 #include "ui/views/controls/menu/menu_item_view.h"
 #include "ui/views/controls/menu/submenu_view.h"
 #include "ui/views/round_rect_painter.h"
 
 using ui::NativeTheme;
 
 // Height of the scroll arrow.
 // This goes up to 4 with large fonts, but this is close enough for now.
 static const int scroll_arrow_height = 3;
 
 namespace views {
 
 namespace {
 
+static const int kBorderPadding = 1;
+
 // MenuScrollButton ------------------------------------------------------------
 
 // MenuScrollButton is used for the scroll buttons when not all menu items fit
 // on screen. MenuScrollButton forwards appropriate events to the
 // MenuController.
 
 class MenuScrollButton : public View {
  public:
   MenuScrollButton(SubmenuView* host, bool is_up)
       : host_(host),
@@ skipping 205 matching lines @@
   // Get the name from the submenu view.
   content_view_->GetAccessibleState(state);
 
   // Now change the role.
   state->role = ui::AccessibilityTypes::ROLE_MENUBAR;
   // Some AT (like NVDA) will not process focus events on menu item children
   // unless a parent claims to be focused.
   state->state = ui::AccessibilityTypes::STATE_FOCUSED;
 }
 
+gfx::Insets MenuScrollViewContainer::GetInsets() const {
+  gfx::Insets insets = View::GetInsets();
+  insets += gfx::Insets(kBorderPadding, kBorderPadding, kBorderPadding,
+      kBorderPadding);
+  return insets;
+}
+
+

[sky, 2013/01/24 22:49:44]

nit: remove whitespace.

[varunjain, 2013/01/25 15:58:07]

Done.

 void MenuScrollViewContainer::OnBoundsChanged(
     const gfx::Rect& previous_bounds) {
   gfx::Size content_pref = scroll_view_->GetContents()->GetPreferredSize();
   scroll_up_button_->SetVisible(content_pref.height() > height());
   scroll_down_button_->SetVisible(content_pref.height() > height());
   Layout();
 }
 
 }  // namespace views