Fix menu corners: the menu background was being painted as a rect when in fact,

ui/views/controls/menu/menu_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/menu/menu_host.h"
 
 #include "ui/gfx/path.h"
 #include "ui/native_theme/native_theme.h"
 #include "ui/views/controls/menu/menu_controller.h"
 #include "ui/views/controls/menu/menu_host_root_view.h"
@@ skipping 18 matching lines @@
 }
 
 void MenuHost::InitMenuHost(Widget* parent,
                             const gfx::Rect& bounds,
                             View* contents_view,
                             bool do_capture) {
   Widget::InitParams params(Widget::InitParams::TYPE_MENU);
   params.has_dropshadow = true;
   params.parent = parent ? parent->GetNativeView() : NULL;
   params.bounds = bounds;
+
+  const MenuConfig& menu_config = submenu_->GetMenuItem()->GetMenuConfig();

[sky, 2013/01/25 20:30:24]

Can you make sure the MenuController is correctly set when you invoke this? By
that I mean make sure MenuItemView::GetMenuConfig() has a MenuController.

[varunjain, 2013/01/25 22:57:29]

I think it does not matter if the controller exists or not. We are just
interested in the corner_radius here, so even if the controller does not exist,
we get the corner_radius from the default MenuConfig::instance().

[sky, 2013/01/25 23:43:18]

If the code falls back to MenuConfig::instance() then it may not be using the
right instance (because of the theme). That's why I mentioned earlier you made
need to make this take a NativeTheme.

[varunjain, 2013/01/28 20:58:01]

my point is that the default value of corner radius is independent of native
theme. if controller does not yet exist, we want to use the default value of
corner_radius, which is what we get from MenuConfig::instance(). I am not sure
what you mean by "it may not be using the right instance". For the case when
controller is not initialized, on WIN, MenuConfig::instance() will give the
instance() defined in menu_config_win and on CHROMEOS, the one defined in
menu_config_views. Isnt that what we want? 

+  if (menu_config.corner_radius > 0)
+    params.transparent = true;
   Init(params);
 
-  if (ui::NativeTheme::IsNewMenuStyleEnabled()) {
+  if (ui::NativeTheme::IsNewMenuStyleEnabled() &&

[sky, 2013/01/25 20:30:24]

I tend to think this code isn't needed at all. SetShape in NativeWidgetAura does
nothing.

[varunjain, 2013/01/25 22:57:29]

I think so too. But I am not very familiar with the new menu style code. If you
are sure, I can remove this, otherwise I would defer to yefim.

[sky, 2013/01/25 23:43:18]

Nuke it.

[varunjain, 2013/01/28 20:58:01]

Done.

+      menu_config.corner_radius > 0) {
     // TODO(yefim): Investigate it more on aura.
     gfx::Path path;
-    RoundRectPainter::CreateRoundRectPath(bounds, &path);
+    RoundRectPainter::CreateRoundRectPath(bounds, &path,
+                                          menu_config.corner_radius);
     SetShape(path.CreateNativeRegion());
   }
 
   SetContentsView(contents_view);
+  if (menu_config.corner_radius > 0)
+    SetOpacity(0);
   ShowMenuHost(do_capture);
 }
 
 bool MenuHost::IsMenuHostVisible() {
   return IsVisible();
 }
 
 void MenuHost::ShowMenuHost(bool do_capture) {
   // Doing a capture may make us get capture lost. Ignore it while we're in the
   // process of showing.
@@ skipping 62 matching lines @@
   if (destroying_)
     return;
 
   MenuController* menu_controller =
       submenu_->GetMenuItem()->GetMenuController();
   if (menu_controller && !menu_controller->drag_in_progress())
     menu_controller->CancelAll();
 }
 
 }  // namespace views