Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2275)

Unified Diff: content/renderer/gpu/compositor_output_surface.cc

Issue 12041062: Have a common implementation of cc::OutputSurface (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/gpu/compositor_output_surface.cc
diff --git a/content/renderer/gpu/compositor_output_surface.cc b/content/renderer/gpu/compositor_output_surface.cc
index 65a6f4a5503b6fa0e8b0b7d12769b7250501c9b2..d51f38187de2df9287e98945861adbde0f88ab41 100644
--- a/content/renderer/gpu/compositor_output_surface.cc
+++ b/content/renderer/gpu/compositor_output_surface.cc
@@ -36,12 +36,11 @@ CompositorOutputSurface::CompositorOutputSurface(
int32 routing_id,
WebGraphicsContext3D* context3D,
cc::SoftwareOutputDevice* software_device)
- : output_surface_filter_(
+ : OutputSurface(make_scoped_ptr(context3D),
+ make_scoped_ptr(software_device)),
+ output_surface_filter_(
RenderThreadImpl::current()->compositor_output_surface_filter()),
- client_(NULL),
- routing_id_(routing_id),
- context3D_(context3D),
- software_device_(software_device) {
+ routing_id_(routing_id) {
DCHECK(output_surface_filter_);
capabilities_.has_parent_compositor = false;
DetachFromThread();
@@ -55,22 +54,12 @@ CompositorOutputSurface::~CompositorOutputSurface() {
output_surface_filter_->RemoveRoute(routing_id_);
}
-const struct cc::OutputSurface::Capabilities&
- CompositorOutputSurface::Capabilities() const {
- DCHECK(CalledOnValidThread());
- return capabilities_;
-}
-
bool CompositorOutputSurface::BindToClient(
cc::OutputSurfaceClient* client) {
DCHECK(CalledOnValidThread());
- DCHECK(!client_);
- if (context3D_.get()) {
- if (!context3D_->makeContextCurrent())
- return false;
- }
- client_ = client;
+ if (!cc::OutputSurface::BindToClient(client))
+ return false;
output_surface_proxy_ = new CompositorOutputSurfaceProxy(this);
output_surface_filter_->AddRoute(
@@ -81,15 +70,6 @@ bool CompositorOutputSurface::BindToClient(
return true;
}
-WebGraphicsContext3D* CompositorOutputSurface::Context3D() const {
- DCHECK(CalledOnValidThread());
- return context3D_.get();
-}
-
-cc::SoftwareOutputDevice* CompositorOutputSurface::SoftwareDevice() const {
- return software_device_.get();
-}
-
void CompositorOutputSurface::SendFrameToParentCompositor(
cc::CompositorFrame* frame) {
DCHECK(CalledOnValidThread());

Powered by Google App Engine
This is Rietveld 408576698