runtime/vm/simulator.h - Issue 12041056: Initial revision of ARM simulator and (empty) MIPS simulator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/vm/simulator.h

Issue 12041056: Initial revision of ARM simulator and (empty) MIPS simulator. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file

	2 // for details. All rights reserved. Use of this source code is governed by a

	3 // BSD-style license that can be found in the LICENSE file.

	4

	5 #ifndef VM_SIMULATOR_H_

	6 #define VM_SIMULATOR_H_

	7

	8 #include "vm/globals.h"

	9

	10 #if defined(TARGET_ARCH_IA32)

	11 // No simulator used.

	12 #elif defined(TARGET_ARCH_X64)

	13 // No simulator used.

	14 #elif defined(TARGET_ARCH_ARM)

	15 #define USING_SIMULATOR
	siva 2013/01/24 02:03:09 in globals.h we have used the pattern "#define <va in globals.h we have used the pattern "#define <variable> 1" There are some inconsistencies with the WIN32 and Android defines. If HOST_ARCH_ARM and TARGET_ARCH_ARM are defined we don't want USING_SIMULATOR to be defined right? You have a #if !defined(HOST_ARCH_ARM) ... #endif wrapping in vm/simulator_arm.h maybe the wrapping should be moved here into this file or "#define USING_SIMULATOR 1" moved to vm/simulator_arm.h regis 2013/01/24 21:47:48 Good point. Fixed. Show quoted text On 2013/01/24 02:03:09, siva wrote: > in globals.h we have used the pattern "#define <variable> 1" > There are some inconsistencies with the WIN32 and Android defines. > > If HOST_ARCH_ARM and TARGET_ARCH_ARM are defined we don't want USING_SIMULATOR > to be defined right? > > You have a #if !defined(HOST_ARCH_ARM) ... #endif wrapping in vm/simulator_arm.h > maybe the wrapping should be moved here into this file or "#define > USING_SIMULATOR 1" moved to vm/simulator_arm.h Good point. Fixed.
	16 #include "vm/simulator_arm.h"

	17 #elif defined(TARGET_ARCH_MIPS)

	18 #define USING_SIMULATOR

	19 #include "vm/simulator_mips.h"
	siva 2013/01/24 02:03:09 Ditto comment for the MIPS case. Ditto comment for the MIPS case. regis 2013/01/24 21:47:48 Done. Show quoted text On 2013/01/24 02:03:09, siva wrote: > Ditto comment for the MIPS case. Done.
	20 #else

	21 #error Unknown architecture.

	22 #endif

	23

	24 #endif // VM_SIMULATOR_H_

OLD	NEW

« runtime/vm/os_win.cc ('K') | « runtime/vm/os_win.cc ('k') | runtime/vm/simulator_arm.h » ('j') | runtime/vm/simulator_arm.h » ('J')