Issue 8051. dart_analyzer return codes on errors

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 822 matching lines @@
             break;
           }
         }
       }
       numStaticTypeAnnotations = optionsFromFile['numStaticTypeAnnotations'];
       numCompileTimeAnnotations = optionsFromFile['numCompileTimeAnnotations'];
       isStaticClean = optionsFromFile['isStaticClean'];
     }
 
     if (errors.length == 0) {
-      if (!hasFatalTypeErrors && exitCode != 0) {
+      if (!hasFatalTypeErrors && !(exitCode == 0 || exitCode == 1)) {
         diagnostics.add("EXIT CODE MISMATCH: Expected error message:");
         diagnostics.add("  command[0]:${testCase.commands[0]}");
         diagnostics.add("  exitCode:${exitCode}");
         return true;
       }
-    } else if (exitCode == 0) {
+    } else if (exitCode == 0 || exitCode == 1) {
       diagnostics.add("EXIT CODE MISMATCH: Unexpected error message:");
       diagnostics.add("  errors[0]:${errors[0]}");
       diagnostics.add("  command[0]:${testCase.commands[0]}");
       diagnostics.add("  exitCode:${exitCode}");
       return true;
     }
     if (numStaticTypeAnnotations > 0 && isStaticClean) {
       diagnostics.add("Cannot have both @static-clean and /// static "
                       "type warning annotations.");
       return true;
@@ skipping 893 matching lines @@
         // the developer doesn't waste his or her time trying to fix a bunch of
         // tests that appear to be broken but were actually just flakes that
         // didn't get retried because there had already been one failure.
         bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
         new RunningProcess(test, allowRetry, this).start();
       }
       _numProcesses++;
     }
   }
 }