Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 12041037: Revert "Set msvs_cygwin_shell default to 0" (Closed)

Created:
7 years, 11 months ago by iannucci
Modified:
7 years, 11 months ago
Reviewers:
iannucci
CC:
chromium-reviews
Visibility:
Public.

Description

Revert "Set msvs_cygwin_shell default to 0" This reverts commit 27a1f2c62be751eb8926f4792cdd3b5d4baac310. I suspect this is causing issues for the Win7 Tests (1) bot. Something went wrong that causes a lot of browser_tests to fail. I suspect that a step is running incorrectly on the build side which causes the packaged build to not work on the testers. http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/19113 TBR=iannucci@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178222

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698