Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 12041005: Optimize loads and stores to Int32Array and Uint32Array. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language.cc
===================================================================
--- runtime/vm/intermediate_language.cc (revision 17337)
+++ runtime/vm/intermediate_language.cc (working copy)
@@ -1128,6 +1128,8 @@
case kExternalUint8ArrayCid:
case kInt16ArrayCid:
case kUint16ArrayCid:
+ case kInt32ArrayCid:
+ case kUint32ArrayCid:
case kOneByteStringCid:
case kTwoByteStringCid:
return Type::IntType();
@@ -1138,80 +1140,11 @@
}
-intptr_t LoadIndexedInstr::ResultCid() const {
- switch (class_id_) {
- case kArrayCid:
- case kImmutableArrayCid:
- return kDynamicCid;
- case kFloat32ArrayCid :
- case kFloat64ArrayCid :
- return kDoubleCid;
- case kInt8ArrayCid:
- case kUint8ArrayCid:
- case kUint8ClampedArrayCid:
- case kExternalUint8ArrayCid:
- case kInt16ArrayCid:
- case kUint16ArrayCid:
- case kOneByteStringCid:
- case kTwoByteStringCid:
- return kSmiCid;
- default:
- UNIMPLEMENTED();
- return kSmiCid;
- }
-}
-
-
-Representation LoadIndexedInstr::representation() const {
- switch (class_id_) {
- case kArrayCid:
- case kImmutableArrayCid:
- case kInt8ArrayCid:
- case kUint8ArrayCid:
- case kUint8ClampedArrayCid:
- case kExternalUint8ArrayCid:
- case kInt16ArrayCid:
- case kUint16ArrayCid:
- case kOneByteStringCid:
- case kTwoByteStringCid:
- return kTagged;
- case kFloat32ArrayCid :
- case kFloat64ArrayCid :
- return kUnboxedDouble;
- default:
- UNIMPLEMENTED();
- return kTagged;
- }
-}
-
-
RawAbstractType* StoreIndexedInstr::CompileType() const {
return AbstractType::null();
}
-Representation StoreIndexedInstr::RequiredInputRepresentation(
- intptr_t idx) const {
- if ((idx == 0) || (idx == 1)) return kTagged;
- ASSERT(idx == 2);
- switch (class_id_) {
- case kArrayCid:
- case kInt8ArrayCid:
- case kUint8ArrayCid:
- case kUint8ClampedArrayCid:
- case kInt16ArrayCid:
- case kUint16ArrayCid:
- return kTagged;
- case kFloat32ArrayCid :
- case kFloat64ArrayCid :
- return kUnboxedDouble;
- default:
- UNIMPLEMENTED();
- return kTagged;
- }
-}
-
-
RawAbstractType* StoreInstanceFieldInstr::CompileType() const {
return value()->CompileType();
}

Powered by Google App Engine
This is Rietveld 408576698