Optimize loads and stores to Int32Array and Uint32Array.

runtime/vm/flow_graph_compiler.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_XXX.
 
 #include "vm/flow_graph_compiler.h"
 
 #include "vm/cha.h"
 #include "vm/dart_entry.h"
@@ skipping 872 matching lines @@
     case kInt8ArrayCid:
       return Int8Array::kBytesPerElement;
     case kUint8ArrayCid:
       return Uint8Array::kBytesPerElement;
     case kUint8ClampedArrayCid:
       return Uint8ClampedArray::kBytesPerElement;
     case kInt16ArrayCid:
       return Int16Array::kBytesPerElement;
     case kUint16ArrayCid:
       return Uint16Array::kBytesPerElement;
+    case kInt32ArrayCid:

[Kevin Millikin (Google), 2013/01/21 15:16:01]

There are several places with boilerplate.  Keep in mind a way to generate them
with macros or templates.

Another alternative is to have a separate enum for the Array subclasses, a
function to map cid to array class ID, and switch over that everywhere --- that
would give a compiler warning for nonexhaustiveness.

[Florian Schneider, 2013/01/21 16:03:25]

I'll keep that in mind for my next change where I want to add all loads/stores
with External* array variants. It would become even more boilerplate.

+      return Int32Array::kBytesPerElement;
+    case kUint32ArrayCid:
+      return Uint32Array::kBytesPerElement;
     case kOneByteStringCid:
       return OneByteString::kBytesPerElement;
     case kTwoByteStringCid:
       return TwoByteString::kBytesPerElement;
     case kExternalUint8ArrayCid:
       return ExternalUint8Array::kBytesPerElement;
     default:
       UNIMPLEMENTED();
       return 0;
   }
@@ skipping 12 matching lines @@
     case kInt8ArrayCid:
       return Int8Array::data_offset();
     case kUint8ArrayCid:
       return Uint8Array::data_offset();
     case kUint8ClampedArrayCid:
       return Uint8ClampedArray::data_offset();
     case kInt16ArrayCid:
       return Int16Array::data_offset();
     case kUint16ArrayCid:
       return Uint16Array::data_offset();
+    case kInt32ArrayCid:
+      return Int32Array::data_offset();
+    case kUint32ArrayCid:
+      return Uint32Array::data_offset();
     case kOneByteStringCid:
       return OneByteString::data_offset();
     case kTwoByteStringCid:
       return TwoByteString::data_offset();
     default:
       UNIMPLEMENTED();
       return Array::data_offset();
   }
 }
 
@@ skipping 47 matching lines @@
     if (i != largest_ix) {
       // Swap.
       CidTarget temp = (*sorted)[i];
       (*sorted)[i] = (*sorted)[largest_ix];
       (*sorted)[largest_ix] = temp;
     }
   }
 }
 
 }  // namespace dart