media/video/capture/video_capture_device.h - Issue 1204063005: Reland: Video Capture: extract storage info from pixel format in VideoCaptureFormat.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/capture/video_capture_device.h

Issue 1204063005: Reland: Video Capture: extract storage info from pixel format in VideoCaptureFormat. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dcheng@s https://codereview.chromium.org/1210743003/#ps20001 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/base/video_capture_types.cc ('K') | « media/video/capture/fake_video_capture_device_unittest.cc ('k') | media/video/capture/video_capture_device_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/video/capture/video_capture_device.h

diff --git a/media/video/capture/video_capture_device.h b/media/video/capture/video_capture_device.h

index 59d91cfc6faa219ac77b1c4afd333c435cb9e7e8..739831628cecb34c4c9079a85b63d41544d30220 100644

--- a/media/video/capture/video_capture_device.h

+++ b/media/video/capture/video_capture_device.h

@@ -247,8 +247,9 @@ class MEDIA_EXPORT VideoCaptureDevice {

// The output buffer stays reserved and mapped for use until the Buffer

// object is destroyed or returned.

virtual scoped_ptr<Buffer> ReserveOutputBuffer(

- media::VideoPixelFormat format,

- const gfx::Size& dimensions) = 0;

+ const gfx::Size& dimensions,

+ VideoPixelFormat format,

+ VideoPixelStorage storage) = 0;

// Captured new video data, held in |frame| or |buffer|, respectively for

// OnIncomingCapturedVideoFrame() and OnIncomingCapturedBuffer().