content/browser/renderer_host/media/video_capture_device_client.h - Issue 1204063005: Reland: Video Capture: extract storage info from pixel format in VideoCaptureFormat.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/video_capture_device_client.h

Issue 1204063005: Reland: Video Capture: extract storage info from pixel format in VideoCaptureFormat. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dcheng@s https://codereview.chromium.org/1210743003/#ps20001 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/video_capture_controller_unittest.cc ('k') | content/browser/renderer_host/media/video_capture_device_client.cc » ('j') | content/browser/renderer_host/media/video_capture_device_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/video_capture_device_client.h

diff --git a/content/browser/renderer_host/media/video_capture_device_client.h b/content/browser/renderer_host/media/video_capture_device_client.h

index e203e94ce09bb3c088001bd5bc2959e545f540b2..2adcd2de2261fc681630533e81d91c18a1bc62ca 100644

--- a/content/browser/renderer_host/media/video_capture_device_client.h

+++ b/content/browser/renderer_host/media/video_capture_device_client.h

@@ -53,8 +53,10 @@ class CONTENT_EXPORT VideoCaptureDeviceClient

const media::VideoCaptureFormat& frame_format,

int clockwise_rotation,

const base::TimeTicks& timestamp) override;

- scoped_ptr<Buffer> ReserveOutputBuffer(media::VideoPixelFormat format,

- const gfx::Size& dimensions) override;

+ scoped_ptr<Buffer> ReserveOutputBuffer(

+ const gfx::Size& dimensions,

+ media::VideoPixelFormat format,

+ media::VideoPixelStorage storage) override;

void OnIncomingCapturedBuffer(scoped_ptr<Buffer> buffer,

const media::VideoCaptureFormat& frame_format,

const base::TimeTicks& timestamp) override;