content/browser/renderer_host/media/video_capture_controller.cc - Issue 1204063005: Reland: Video Capture: extract storage info from pixel format in VideoCaptureFormat.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/video_capture_controller.cc

Issue 1204063005: Reland: Video Capture: extract storage info from pixel format in VideoCaptureFormat. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dcheng@s https://codereview.chromium.org/1210743003/#ps20001 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc ('k') | content/browser/renderer_host/media/video_capture_controller_unittest.cc » ('j') | content/browser/renderer_host/media/video_capture_device_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/video_capture_controller.cc

diff --git a/content/browser/renderer_host/media/video_capture_controller.cc b/content/browser/renderer_host/media/video_capture_controller.cc

index e799b36093cfc5b6d37e38c6af40d1770129f926..8fbab0ad6762accf9a8a78dd82ba0bf2590e2d4b 100644

--- a/content/browser/renderer_host/media/video_capture_controller.cc

+++ b/content/browser/renderer_host/media/video_capture_controller.cc

@@ -324,7 +324,6 @@ void VideoCaptureController::DoIncomingCapturedVideoFrameOnIOThread(

DCHECK(frame->coded_size() == frame->visible_rect().size())

<< "Textures are always supposed to be tightly packed.";

DCHECK_EQ(1u, VideoFrame::NumPlanes(frame->format()));

} else if (frame->format() == VideoFrame::I420) {

const bool is_new_buffer =

client->known_buffers.insert(buffer_id).second;