Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1967)

Unified Diff: remoting/webapp/unittests/spy_promise_unittest.js

Issue 1204023003: remoting: Fix JSCompiler issues blocking ES6 transition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove one. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/unittests/spy_promise_unittest.js
diff --git a/remoting/webapp/unittests/spy_promise_unittest.js b/remoting/webapp/unittests/spy_promise_unittest.js
index 099ba09c78c2779dda43733d3ca98e084dfc3f6a..8071248a2042a6e114cc2b1975ed8b9fcf31b63c 100644
--- a/remoting/webapp/unittests/spy_promise_unittest.js
+++ b/remoting/webapp/unittests/spy_promise_unittest.js
@@ -30,9 +30,10 @@ function assertInitialState(/** QUnit.Assert */ assert) {
}
/**
+ * @param {!QUnit.Assert} assert
* @return {!Promise}
*/
-function finish(/** QUnit.Assert */ assert) {
+function finish(assert) {
return base.SpyPromise.settleAll().then(function() {
assert.equal(
base.SpyPromise.unsettledCount, 0,
@@ -143,11 +144,13 @@ QUnit.test('reject/catch', function(assert) {
QUnit.test('all', function(assert) {
var done = assert.async();
base.SpyPromise.all([Promise.resolve(1), Promise.resolve(2)]).
- then(function(/**string*/ value) {
- assert.equal(base.SpyPromise.unsettledCount, 0);
- assert.deepEqual(value, [1, 2]);
- done();
- });
+ then(
+ /** @param {string} value */
+ function(value) {
+ assert.equal(base.SpyPromise.unsettledCount, 0);
+ assert.deepEqual(value, [1, 2]);
+ done();
+ });
assert.equal(base.SpyPromise.unsettledCount, 1);
return finish(assert);
});
« remoting/webapp/base/js/base.js ('K') | « remoting/webapp/js_proto/chrome_mocks.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698