Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Unified Diff: remoting/webapp/base/js/base.js

Issue 1204023003: remoting: Fix JSCompiler issues blocking ES6 transition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove one. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/webapp/base/js/error.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/base/js/base.js
diff --git a/remoting/webapp/base/js/base.js b/remoting/webapp/base/js/base.js
index 1f853ccd168b63f14425e5a30ca2e6437900a29b..480d58ddc1f73e2314e9ac445554e6110c72b673 100644
--- a/remoting/webapp/base/js/base.js
+++ b/remoting/webapp/base/js/base.js
@@ -65,6 +65,7 @@ base.Disposable.prototype.dispose = function() {};
* @constructor
* @param {...base.Disposable} var_args
* @implements {base.Disposable}
+ * @suppress {reportUnknownTypes}
Jamie 2015/06/24 23:50:18 Can you add something to the CL description explai
James Hawkins 2015/06/25 00:00:44 You're not losing type checking. You're suppressi
Jamie 2015/06/25 00:10:49 So am I right in thinking that the old compiler (o
*/
base.Disposables = function(var_args) {
/**
@@ -76,6 +77,7 @@ base.Disposables = function(var_args) {
/**
* @param {...base.Disposable} var_args
+ * @suppress {reportUnknownTypes}
*/
base.Disposables.prototype.add = function(var_args) {
var disposables = Array.prototype.slice.call(arguments, 0);
@@ -90,6 +92,7 @@ base.Disposables.prototype.add = function(var_args) {
/**
* @param {...base.Disposable} var_args Dispose |var_args| and remove
* them from the current object.
+ * @suppress {reportUnknownTypes}
*/
base.Disposables.prototype.remove = function(var_args) {
var disposables = Array.prototype.slice.call(arguments, 0);
« no previous file with comments | « no previous file | remoting/webapp/base/js/error.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698