remoting: Fix JSCompiler issues blocking ES6 transition.

remoting/webapp/base/js/base.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * A module that contains basic utility components and methods for the
  * chromoting project
  *
  */
@@ skipping 47 matching lines @@
 /**
   * @interface
   */
 base.Disposable = function() {};
 base.Disposable.prototype.dispose = function() {};
 
 /**
  * @constructor
  * @param {...base.Disposable} var_args
  * @implements {base.Disposable}
+ * @suppress {reportUnknownTypes}

[Jamie, 2015/06/24 23:50:18]

Can you add something to the CL description explaining why this is a net win? On
the face of it, we're losing type checking here; I hope that's not actually the
case, but either way, the CL should explain why we're doing it, especially with
no bug to refer to.

[James Hawkins, 2015/06/25 00:00:44]

You're not losing type checking.  You're suppressing a warning for type
operations the compiler does not know about.  In every suppression in this CL,
the issue revolves around the use of |arguments|, whose type is not well-handled
by the JSCompiler (which I wrote in the description).

[Jamie, 2015/06/25 00:10:49]

So am I right in thinking that the old compiler (or flags) did not enforce this
type check, but neither did it issue a warning,  whereas the new version issues
a warning, which we must suppress? If that's the case, then I have no objection;
it just wasn't clear without context that that's what's going on here.

  */
 base.Disposables = function(var_args) {
   /**
    * @type {Array<base.Disposable>}
    * @private
    */
   this.disposables_ = Array.prototype.slice.call(arguments, 0);
 };
 
 /**
  * @param {...base.Disposable} var_args
+ * @suppress {reportUnknownTypes}
  */
 base.Disposables.prototype.add = function(var_args) {
   var disposables = Array.prototype.slice.call(arguments, 0);
   for (var i = 0; i < disposables.length; i++) {
     var current = /** @type {base.Disposable} */ (disposables[i]);
     if (this.disposables_.indexOf(current) === -1) {
       this.disposables_.push(current);
     }
   }
 };
 
 /**
  * @param {...base.Disposable} var_args  Dispose |var_args| and remove
  *    them from the current object.
+ * @suppress {reportUnknownTypes}
  */
 base.Disposables.prototype.remove = function(var_args) {
   var disposables = Array.prototype.slice.call(arguments, 0);
   for (var i = 0; i < disposables.length; i++) {
     var disposable = /** @type {base.Disposable} */ (disposables[i]);
     var index = this.disposables_.indexOf(disposable);
     if(index !== -1) {
       this.disposables_.splice(index, 1);
       disposable.dispose();
     }
@@ skipping 709 matching lines @@
   var height = Math.ceil(document.documentElement.scrollHeight + borderY);
   appWindow.outerBounds.width = width;
   appWindow.outerBounds.height = height;
   if (opt_centerWindow) {
     var screenWidth = screen.availWidth;
     var screenHeight = screen.availHeight;
     appWindow.outerBounds.left = Math.round((screenWidth - width) / 2);
     appWindow.outerBounds.top = Math.round((screenHeight - height) / 2);
   }
 };