Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1204013003: Revert of Extend big-disjunction optimization to case-independent regexps (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Extend big-disjunction optimization to case-independent regexps (patchset #5 id:80001 of https://codereview.chromium.org/1182783009/) Reason for revert: [Sheriff] Test times out now on msan: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/2947 Original issue's description: > Extend big-disjunction optimization to case-independent regexps > > R=yangguo@chromium.org > BUG=chromium:482998 > LOG=n > > Committed: https://crrev.com/d2135603bcf462e15a1284d8ed969f6692610dda > Cr-Commit-Position: refs/heads/master@{#29264} TBR=yangguo@chromium.org,erikcorry@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:482998 Committed: https://crrev.com/3eae40d7a4ea98e974a5e936bd4665320000e366 Cr-Commit-Position: refs/heads/master@{#29266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -149 lines) Patch
M src/heap-snapshot-generator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/jsregexp.cc View 5 chunks +9 lines, -56 lines 0 comments Download
M src/list.h View 1 chunk +5 lines, -8 lines 0 comments Download
M src/list-inl.h View 2 chunks +6 lines, -9 lines 0 comments Download
M src/vector.h View 2 chunks +14 lines, -21 lines 0 comments Download
D test/mjsunit/regexp-sort.js View 1 chunk +0 lines, -48 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-482998.js View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Extend big-disjunction optimization to case-independent regexps
5 years, 6 months ago (2015-06-24 19:03:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204013003/1
5 years, 6 months ago (2015-06-24 19:03:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-24 19:04:12 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 19:04:23 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3eae40d7a4ea98e974a5e936bd4665320000e366
Cr-Commit-Position: refs/heads/master@{#29266}

Powered by Google App Engine
This is Rietveld 408576698