Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 12040095: chromeos: Rename DriveDownloadHandler::GetDrivePath() to GetTargetPath(), make it return full path (Closed)

Created:
7 years, 11 months ago by hashimoto
Modified:
7 years, 10 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, benjhayden+dwatch_chromium.org, achuith+watch_chromium.org, rdsmith+dwatch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Rename DriveDownloadHandler::GetDrivePath() to GetTargetPath(), make it return full path 'drive path' (e.g. drive/foo.jpg) extracted by drive::util::ExtractDrivePath() is only useful when dealing with DriveFileSystem. In all other cases, including when opening files with FileManager, full path (/special/drive/foo.jpg) is more useful. BUG=154713 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179529

Patch Set 1 : _ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -17 lines) Patch
M chrome/browser/chromeos/drive/drive_download_handler.h View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_download_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/download_file_picker_chromeos.cc View 2 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hashimoto
kinaba: Please review chromeos/drive rdsmith: Please review download_file_picker_chromeos.cc
7 years, 11 months ago (2013-01-25 09:58:15 UTC) #1
kinaba
lgtm
7 years, 11 months ago (2013-01-25 10:16:39 UTC) #2
Randy Smith (Not in Mondays)
Achuith: REasonable to ask you to do file_picker_chromeos? I think you know that file better ...
7 years, 11 months ago (2013-01-25 17:07:26 UTC) #3
hashimoto
Randy, Sorry for being unclear. What I wanted was your owner LGTM. BTW, do you ...
7 years, 10 months ago (2013-01-29 14:06:34 UTC) #4
Randy Smith (Not in Mondays)
First of all, LGTM :-}. With regard to your OWNERS request, I'm in a bit ...
7 years, 10 months ago (2013-01-29 16:10:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/12040095/2001
7 years, 10 months ago (2013-01-30 02:07:23 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-01-30 04:56:23 UTC) #7
Message was sent while issue was closed.
Change committed as 179529

Powered by Google App Engine
This is Rietveld 408576698