Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 12040055: Fix no-compile tests in base. (Closed)

Created:
7 years, 11 months ago by dcheng
Modified:
7 years, 11 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Visibility:
Public.

Description

Fix no-compile tests in base. - Fixed a nocompile test wasn't ever no compiled (probably a side effect of http://crrev.com/111889) and never worked. - Updated the error messages to those used by gcc 4.6 in Precise - Minor improvement to the nocompile driver that makes the compiler output more friendly when the regex includes a single quote. Hopefully no one needs to match a double quote for awhile... TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178434

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -21 lines) Patch
M base/bind_unittest.nc View 5 chunks +5 lines, -5 lines 0 comments Download
M base/memory/scoped_ptr_unittest.nc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/memory/weak_ptr_unittest.nc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/safe_numerics_unittest.nc View 1 chunk +17 lines, -5 lines 0 comments Download
M tools/nocompile_driver.py View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dcheng
7 years, 11 months ago (2013-01-23 23:25:19 UTC) #1
awong
Have you tried this on a non-UTF-8 locale?
7 years, 11 months ago (2013-01-23 23:35:58 UTC) #2
dcheng
On 2013/01/23 23:35:58, awong wrote: > Have you tried this on a non-UTF-8 locale? Doesn't ...
7 years, 11 months ago (2013-01-23 23:42:21 UTC) #3
awong
LGTM Ahhahaha...I forgot the LC_ALL="C" was there. :P
7 years, 11 months ago (2013-01-23 23:43:45 UTC) #4
dcheng
TBRing darin since the no compiled tests aren't typically... compiled.
7 years, 11 months ago (2013-01-23 23:49:11 UTC) #5
dcheng
7 years, 11 months ago (2013-01-23 23:49:34 UTC) #6
(TBRing darin for real this time)

Powered by Google App Engine
This is Rietveld 408576698