Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 12040042: Merged r13480, r13481 into trunk branch. (Closed)

Created:
7 years, 11 months ago by mvstanton
Modified:
7 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Merged r13480, r13481 into trunk branch. Always fail when trying to store to an undeclared global variable, even if it was found. Fix corner case when JSFunction is evicted from flusher. BUG=chromium:168801 R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=13482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -38 lines) Patch
M src/ic.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ic.cc View 5 chunks +6 lines, -9 lines 0 comments Download
M src/mark-compact.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + test/cctest/test-global-object.cc View 1 chunk +20 lines, -19 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mvstanton
7 years, 11 months ago (2013-01-23 16:27:19 UTC) #1
Jakob Kummerow
7 years, 11 months ago (2013-01-23 16:28:15 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698