Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Side by Side Diff: cc/delegated_renderer_layer_impl.cc

Issue 12040011: cc: Clip delegated quads to the correct clip rect. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased-on-no-clipped_rect_in_target Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | cc/delegated_renderer_layer_impl_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/delegated_renderer_layer_impl.h" 5 #include "cc/delegated_renderer_layer_impl.h"
6 6
7 #include "cc/append_quads_data.h" 7 #include "cc/append_quads_data.h"
8 #include "cc/math_util.h" 8 #include "cc/math_util.h"
9 #include "cc/quad_sink.h" 9 #include "cc/quad_sink.h"
10 #include "cc/render_pass_draw_quad.h" 10 #include "cc/render_pass_draw_quad.h"
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 void DelegatedRendererLayerImpl::appendRenderPassQuads(QuadSink& quadSink, Appen dQuadsData& appendQuadsData, const RenderPass* delegatedRenderPass, gfx::Size fr ameSize) const 135 void DelegatedRendererLayerImpl::appendRenderPassQuads(QuadSink& quadSink, Appen dQuadsData& appendQuadsData, const RenderPass* delegatedRenderPass, gfx::Size fr ameSize) const
136 { 136 {
137 const SharedQuadState* currentSharedQuadState = 0; 137 const SharedQuadState* currentSharedQuadState = 0;
138 SharedQuadState* copiedSharedQuadState = 0; 138 SharedQuadState* copiedSharedQuadState = 0;
139 for (size_t i = 0; i < delegatedRenderPass->quad_list.size(); ++i) { 139 for (size_t i = 0; i < delegatedRenderPass->quad_list.size(); ++i) {
140 const DrawQuad* quad = delegatedRenderPass->quad_list[i]; 140 const DrawQuad* quad = delegatedRenderPass->quad_list[i];
141 141
142 if (quad->shared_quad_state != currentSharedQuadState) { 142 if (quad->shared_quad_state != currentSharedQuadState) {
143 currentSharedQuadState = quad->shared_quad_state; 143 currentSharedQuadState = quad->shared_quad_state;
144 copiedSharedQuadState = quadSink.useSharedQuadState(currentSharedQua dState->Copy()); 144 copiedSharedQuadState = quadSink.useSharedQuadState(currentSharedQua dState->Copy());
145 bool targetIsFromDelegatedRendererLayer = appendQuadsData.renderPass Id.layer_id == id(); 145 bool isRootDelegatedRenderPass = delegatedRenderPass == m_renderPass esInDrawOrder.back();
146 if (!targetIsFromDelegatedRendererLayer) { 146 if (isRootDelegatedRenderPass) {
147 // Should be the root render pass.
148 DCHECK(delegatedRenderPass == m_renderPassesInDrawOrder.back());
149 // This layer must be drawing to a renderTarget other than itself.
150 DCHECK(renderTarget() != this);
151
152 // Don't allow areas inside the bounds that are empty. 147 // Don't allow areas inside the bounds that are empty.
153 DCHECK(m_displaySize.IsEmpty() || gfx::Rect(m_displaySize).Contain s(gfx::Rect(bounds()))); 148 DCHECK(m_displaySize.IsEmpty() || gfx::Rect(m_displaySize).Contain s(gfx::Rect(bounds())));
154 gfx::Size displaySize = m_displaySize.IsEmpty() ? bounds() : m_dis playSize; 149 gfx::Size displaySize = m_displaySize.IsEmpty() ? bounds() : m_dis playSize;
155 150
156 gfx::Transform delegatedFrameToLayerSpaceTransform; 151 gfx::Transform delegatedFrameToLayerSpaceTransform;
157 delegatedFrameToLayerSpaceTransform.Scale( 152 delegatedFrameToLayerSpaceTransform.Scale(
158 static_cast<double>(displaySize.width()) / frameSize.width(), 153 static_cast<double>(displaySize.width()) / frameSize.width(),
159 static_cast<double>(displaySize.height()) / frameSize.height() ); 154 static_cast<double>(displaySize.height()) / frameSize.height() );
160 155
161 copiedSharedQuadState->content_to_target_transform = drawTransform () * delegatedFrameToLayerSpaceTransform * copiedSharedQuadState->content_to_tar get_transform; 156 copiedSharedQuadState->content_to_target_transform = drawTransform () * delegatedFrameToLayerSpaceTransform * copiedSharedQuadState->content_to_tar get_transform;
162 copiedSharedQuadState->clip_rect = MathUtil::mapClippedRect(drawTr ansform() * delegatedFrameToLayerSpaceTransform, copiedSharedQuadState->clip_rec t); 157
158 if (renderTarget() == this) {
159 DCHECK(!isClipped());
160 DCHECK(renderSurface());
161 copiedSharedQuadState->clip_rect = MathUtil::mapClippedRect(
162 drawTransform() * delegatedFrameToLayerSpaceTransform,
163 copiedSharedQuadState->clip_rect);
164 } else {
165 gfx::Rect clip_rect = drawableContentRect();
166 if (copiedSharedQuadState->is_clipped) {
167 clip_rect.Intersect(MathUtil::mapClippedRect(
168 drawTransform() * delegatedFrameToLayerSpaceTransform,
169 copiedSharedQuadState->clip_rect));
170 }
171 copiedSharedQuadState->clip_rect = clip_rect;
172 copiedSharedQuadState->is_clipped = true;
173 }
174
163 copiedSharedQuadState->opacity *= drawOpacity(); 175 copiedSharedQuadState->opacity *= drawOpacity();
164 } 176 }
165 } 177 }
166 DCHECK(copiedSharedQuadState); 178 DCHECK(copiedSharedQuadState);
167 179
168 scoped_ptr<DrawQuad> copyQuad; 180 scoped_ptr<DrawQuad> copyQuad;
169 if (quad->material != DrawQuad::RENDER_PASS) 181 if (quad->material != DrawQuad::RENDER_PASS)
170 copyQuad = quad->Copy(copiedSharedQuadState); 182 copyQuad = quad->Copy(copiedSharedQuadState);
171 else { 183 else {
172 RenderPass::Id contributingDelegatedRenderPassId = RenderPassDrawQua d::MaterialCast(quad)->render_pass_id; 184 RenderPass::Id contributingDelegatedRenderPassId = RenderPassDrawQua d::MaterialCast(quad)->render_pass_id;
173 RenderPass::Id contributingRenderPassId = convertDelegatedRenderPass Id(contributingDelegatedRenderPassId); 185 RenderPass::Id contributingRenderPassId = convertDelegatedRenderPass Id(contributingDelegatedRenderPassId);
174 DCHECK(contributingRenderPassId != appendQuadsData.renderPassId); 186 DCHECK(contributingRenderPassId != appendQuadsData.renderPassId);
175 187
176 copyQuad = RenderPassDrawQuad::MaterialCast(quad)->Copy(copiedShared QuadState, contributingRenderPassId).PassAs<DrawQuad>(); 188 copyQuad = RenderPassDrawQuad::MaterialCast(quad)->Copy(copiedShared QuadState, contributingRenderPassId).PassAs<DrawQuad>();
177 } 189 }
178 DCHECK(copyQuad.get()); 190 DCHECK(copyQuad.get());
179 191
180 quadSink.append(copyQuad.Pass(), appendQuadsData); 192 quadSink.append(copyQuad.Pass(), appendQuadsData);
181 } 193 }
182 } 194 }
183 195
184 const char* DelegatedRendererLayerImpl::layerTypeAsString() const 196 const char* DelegatedRendererLayerImpl::layerTypeAsString() const
185 { 197 {
186 return "DelegatedRendererLayer"; 198 return "DelegatedRendererLayer";
187 } 199 }
188 200
189 } // namespace cc 201 } // namespace cc
OLDNEW
« no previous file with comments | « no previous file | cc/delegated_renderer_layer_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698