content/browser/download/download_item_impl_delegate.h - Issue 1203983004: Stop using SpawnedTestServer in DownloadContentTest.*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_item_impl_delegate.h

Issue 1203983004: Stop using SpawnedTestServer in DownloadContentTest.* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/download_browsertest.cc ('K') | « content/browser/download/download_browsertest.cc ('k') | content/browser/download/download_manager_impl.cc » ('j') | net/tools/testserver/testserver.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_item_impl_delegate.h

diff --git a/content/browser/download/download_item_impl_delegate.h b/content/browser/download/download_item_impl_delegate.h

index 72e079b89630673cae049b706f29db81480f8fef..70dedd4e79f55fa457ab1c750322760959c6d786 100644

--- a/content/browser/download/download_item_impl_delegate.h

+++ b/content/browser/download/download_item_impl_delegate.h

@@ -26,8 +26,8 @@ class CONTENT_EXPORT DownloadItemImplDelegate {

const base::FilePath&, // Target path

DownloadItem::TargetDisposition, // overwrite/uniquify target

DownloadDangerType,

- const base::FilePath& // Intermediate file path

- )> DownloadTargetCallback;

+ const base::FilePath& // Intermediate file path

svaldez 2015/11/11 20:42:41 Might want to exclude this change, or unify spacin

asanka 2015/11/11 20:57:25 This was 'git cl format's doing. But removed since

+ )> DownloadTargetCallback;

// The boolean argument indicates whether or not the download was

// actually opened.