Stop using SpawnedTestServer in DownloadContentTest.*

content/browser/download/download_manager_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/download_manager_impl.h"
 
 #include <iterator>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 83 matching lines @@
         "Range",
         base::StringPrintf("bytes=%" PRId64 "-", params->offset()),
         true);
 
     if (has_last_modified) {
       request->SetExtraRequestHeaderByName("If-Unmodified-Since",
                                            params->last_modified(),
                                            true);
     }
     if (has_etag) {
-      request->SetExtraRequestHeaderByName("If-Match", params->etag(), true);
+      request->SetExtraRequestHeaderByName("If-Range", params->etag(), true);

[Randy Smith (Not in Mondays), 2015/11/12 00:57:57]

a-r nit: Should this be in this CL?  It looks like a real bug if this needed to
be changed.

[asanka, 2015/11/13 21:40:01]

I'll make another CL and make this CL depend on that for the change from
If-Match to If-Range. This isn't a correctness bug, but rather an efficiency
improvement.

If-Match results in a compliant server sending an HTTP 412 in the case of an
ETag mismatch. Then the downloads logic needs to send an unconditionalized
request to fetch the entire resource.

If-Range, on the other hand, will respond with a 200 along with the entire
entity if there's an ETag mismatch. It's just one request shorter.

     }
   }
 
   for (DownloadUrlParameters::RequestHeadersType::const_iterator iter
            = params->request_headers_begin();
        iter != params->request_headers_end();
        ++iter) {
     request->SetExtraRequestHeaderByName(
         iter->first, iter->second, false /*overwrite*/);
   }
@@ skipping 634 matching lines @@
   if (delegate_)
     delegate_->OpenDownload(download);
 }
 
 void DownloadManagerImpl::ShowDownloadInShell(DownloadItemImpl* download) {
   if (delegate_)
     delegate_->ShowDownloadInShell(download);
 }
 
 }  // namespace content