Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1203983003: Revert of remove SK_SUPPORT_LEGACY_PATHOP_ENUMS (Closed)

Created:
5 years, 6 months ago by scroggo
Modified:
5 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of remove SK_SUPPORT_LEGACY_PATHOP_ENUMS (patchset #1 id:1 of https://codereview.chromium.org/1200323005/) Reason for revert: Breaking the Android build. Original issue's description: > remove SK_SUPPORT_LEGACY_PATHOP_ENUMS > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/8bcc7a00febd737f7e82513bd5e4a697526626de TBR=reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/ba9a4aa8550c982c480d03cb6ba2cabaf6209b41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M include/pathops/SkPathOps.h View 2 chunks +13 lines, -0 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scroggo
Created Revert of remove SK_SUPPORT_LEGACY_PATHOP_ENUMS
5 years, 6 months ago (2015-06-24 15:05:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203983003/1
5 years, 6 months ago (2015-06-24 15:05:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/ba9a4aa8550c982c480d03cb6ba2cabaf6209b41
5 years, 6 months ago (2015-06-24 15:05:57 UTC) #3
tomhudson
Working on a framework CL to enable this.
5 years, 6 months ago (2015-06-24 15:09:27 UTC) #4
tomhudson
This CL should perhaps also fix the strings in src/utils/debugger/SkDebugCanvas.cpp?
5 years, 6 months ago (2015-06-24 15:11:57 UTC) #5
reed1
5 years, 6 months ago (2015-06-26 17:22:51 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1218523002/ by reed@google.com.

The reason for reverting is: fixes have landed in android.

Powered by Google App Engine
This is Rietveld 408576698