src/heap/heap.cc - Issue 1203973002: Serializer: clear next link in weak cells.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 1203973002: Serializer: clear next link in weak cells. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix asan failure Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index df1ba3129f859c61163561df1e709de6d1b2dd4a..bad4528ff4dee805a10f0d4532960276a8c29eb1 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -3126,7 +3126,7 @@ AllocationResult Heap::AllocateWeakCell(HeapObject* value) {

}

result->set_map_no_write_barrier(weak_cell_map());

WeakCell::cast(result)->initialize(value);

- WeakCell::cast(result)->set_next(the_hole_value(), SKIP_WRITE_BARRIER);

+ WeakCell::cast(result)->clear_next(this);

return result;

}

« no previous file with comments | « no previous file | src/heap/mark-compact.cc » ('j') | no next file with comments »