Serializer: clear next link in weak cells.

src/snapshot/serialize.cc

Index: src/snapshot/serialize.cc
diff --git a/src/snapshot/serialize.cc b/src/snapshot/serialize.cc
index 7410c3b393c1a931d991f7f0d1304a75e430e022..733ae2f2396ee9f609a572d95ded4e52c301cf99 100644
--- a/src/snapshot/serialize.cc
+++ b/src/snapshot/serialize.cc
@@ -1851,6 +1851,27 @@ void Serializer::ObjectSerializer::SerializeExternalString() {
 }
 
 
+// Clear and later restore the next link in the weak cell, if the object is one.
+class UnlinkWeakCellScope {
+ public:
+  explicit UnlinkWeakCellScope(HeapObject* object) : weak_cell_(NULL) {
+    if (object->IsWeakCell()) {
+      weak_cell_ = WeakCell::cast(object);
+      next_ = weak_cell_->next();
+      weak_cell_->clear_next(object->GetHeap());
+    }
+  }
+
+  ~UnlinkWeakCellScope() {
+    if (weak_cell_) weak_cell_->set_next(next_);

[ulan, 2015/06/24 11:11:19]

set_next(next_, UPDATE_WEAK_WRITE_BARRIER)

+  }
+
+ private:
+  WeakCell* weak_cell_;
+  Object* next_;
+};
+
+
 void Serializer::ObjectSerializer::Serialize() {
   if (FLAG_trace_serializer) {
     PrintF(" Encoding heap object: ");
@@ -1910,6 +1931,8 @@ void Serializer::ObjectSerializer::Serialize() {
     return;
   }
 
+  UnlinkWeakCellScope unlink_weak_cell(object_);

[ulan, 2015/06/24 11:11:19]

Please add disallow allocation scope here or in UnlinkWeakCellScope.

+
   object_->IterateBody(map->instance_type(), size, this);
   OutputRawData(object_->address() + size);
 }
@@ -1934,6 +1957,8 @@ void Serializer::ObjectSerializer::SerializeDeferred() {
   serializer_->PutBackReference(object_, reference);
   sink_->PutInt(size >> kPointerSizeLog2, "deferred object size");
 
+  UnlinkWeakCellScope unlink_weak_cell(object_);

[ulan, 2015/06/24 11:11:19]

Please add disallow allocation scope here or in UnlinkWeakCellScope.

+
   object_->IterateBody(map->instance_type(), size, this);
   OutputRawData(object_->address() + size);
 }