Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 120393003: HTMLEntityTable could use char to reduce binary size (Closed)

Created:
6 years, 11 months ago by vanihegde
Modified:
6 years, 9 months ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org, vani
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

HTMLEntityTable could use char to reduce binary size Merging from webkit CL http://trac.webkit.org/changeset/155559 Using LChar instead of UChar in HTMLEntityTable reduces the binary size by around 18Kb. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164437

Patch Set 1 #

Patch Set 2 : For review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M Source/core/html/parser/HTMLEntityParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLEntityTable.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/parser/create-html-entity-table View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vanihegde
Without Fix: -------------- section size addr .rodata 18946622 77928704 -------------------------------------------------- Total 112990481 -------------------------------------------------- With Fix: ...
6 years, 11 months ago (2014-01-02 08:39:12 UTC) #1
Daniel Bratell
On 2014/01/02 08:39:12, vanihegde wrote: > Without Fix: > -------------- > section size addr > ...
6 years, 11 months ago (2014-01-02 11:15:25 UTC) #2
vanihegde
> You probably don't want the libpeerconnection.log file. Please ignore the first patch set, it ...
6 years, 11 months ago (2014-01-02 11:26:41 UTC) #3
ojan
6 years, 11 months ago (2014-01-02 23:13:36 UTC) #4
abarth-chromium
lgtm Thanks!!
6 years, 11 months ago (2014-01-02 23:47:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vani.hegde@samsung.com/120393003/20001
6 years, 11 months ago (2014-01-02 23:47:38 UTC) #6
commit-bot: I haz the power
Change committed as 164437
6 years, 11 months ago (2014-01-03 01:04:35 UTC) #7
Daniel Bratell
6 years, 9 months ago (2014-03-13 14:22:27 UTC) #8
Message was sent while issue was closed.
On 2014/01/03 01:04:35, I haz the power (commit-bot) wrote:
> Change committed as 164437

Powered by Google App Engine
This is Rietveld 408576698