Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1203923006: sky home update (Closed)

Created:
5 years, 6 months ago by cpu_(ooo_6.6-7.5)
Modified:
5 years, 6 months ago
Reviewers:
eseidel, Hixie
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

sky home update -replace UINode for Widget -add the minedigger demo -fix spelling of astroids BUG=none R=eseidel@chromium.org, ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/a6bf5b8e943522524e24f48bd47dc54bb8d2b3e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M sky/home.dart View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
cpu_(ooo_6.6-7.5)
I have not tested on android myself but it was not loading on linux and ...
5 years, 6 months ago (2015-06-24 20:38:11 UTC) #2
eseidel
lgtm
5 years, 6 months ago (2015-06-24 20:40:59 UTC) #3
Hixie
lgtm
5 years, 6 months ago (2015-06-24 20:41:47 UTC) #5
cpu_(ooo_6.6-7.5)
5 years, 6 months ago (2015-06-24 20:44:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a6bf5b8e943522524e24f48bd47dc54bb8d2b3e2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698