Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 1203923002: voice_search_ui: Simplify code for displaying Booleans. (Closed)

Created:
5 years, 6 months ago by Matt Giuca
Modified:
5 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@hotword-clarify-labels
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

voice_search_ui: Simplify code for displaying Booleans. Adds wrapper function AddPairBool so each call site doesn't need to provide a string "Yes" or "No". BUG=503496 Committed: https://crrev.com/5cb2c2b99e9b882d15ef58a42e8a316fe80009e1 Cr-Commit-Position: refs/heads/master@{#335887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -26 lines) Patch
M chrome/browser/ui/webui/voice_search_ui.cc View 3 chunks +22 lines, -26 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Matt Giuca
Follow-up to https://codereview.chromium.org/1196243003/#msg12
5 years, 6 months ago (2015-06-24 03:30:01 UTC) #2
Peter Kasting
LGTM
5 years, 6 months ago (2015-06-24 07:01:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203923002/1
5 years, 6 months ago (2015-06-24 07:55:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-24 08:42:56 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 08:43:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5cb2c2b99e9b882d15ef58a42e8a316fe80009e1
Cr-Commit-Position: refs/heads/master@{#335887}

Powered by Google App Engine
This is Rietveld 408576698