Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7624)

Unified Diff: chrome/browser/metrics/metrics_service.h

Issue 12039079: content: convert user action notification to observer usage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/metrics_service.cc » ('j') | content/public/browser/user_metrics.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_service.h
diff --git a/chrome/browser/metrics/metrics_service.h b/chrome/browser/metrics/metrics_service.h
index 308fe57ba1db9653251effc95e3bf085f6b34f16..590235cc6f44f26992bebbc6b023c6453fde9e4e 100644
--- a/chrome/browser/metrics/metrics_service.h
+++ b/chrome/browser/metrics/metrics_service.h
@@ -24,6 +24,7 @@
#include "chrome/installer/util/google_update_settings.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
+#include "content/public/browser/user_metrics.h"
#include "net/url_request/url_fetcher_delegate.h"
#if defined(OS_CHROMEOS)
@@ -71,6 +72,7 @@ struct WebPluginInfo;
class MetricsService
: public chrome_browser_metrics::TrackingSynchronizerObserver,
public content::NotificationObserver,
+ public content::UserMetricsObserver,
public net::URLFetcherDelegate,
public MetricsServiceBase {
public:
@@ -137,6 +139,9 @@ class MetricsService
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
+ // Implementation of content::UserMetricsObserver
+ virtual void UserAction(const std::string& action) OVERRIDE;
+
// Invoked when we get a WM_SESSIONEND. This places a value in prefs that is
// reset when RecordCompletedSessionEnd is invoked.
void RecordStartOfSessionEnd();
@@ -398,9 +403,7 @@ class MetricsService
const content::NotificationDetails& details);
// Checks whether a notification can be logged.
- bool CanLogNotification(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details);
+ bool CanLogNotification();
// Sets the value of the specified path in prefs and schedules a save.
void RecordBooleanPrefValue(const char* path, bool value);
« no previous file with comments | « no previous file | chrome/browser/metrics/metrics_service.cc » ('j') | content/public/browser/user_metrics.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698