History: Fix RTL layout in grouped history and some other minor fixes.

chrome/browser/resources/history/history.css

Index: chrome/browser/resources/history/history.css
diff --git a/chrome/browser/resources/history/history.css b/chrome/browser/resources/history/history.css
index 74d2e3de979955bd78f771d45512ccbae51c1a85..971dcd7442d1d67fc82dd0fc57cbf3a8de9d9c8f 100644
--- a/chrome/browser/resources/history/history.css
+++ b/chrome/browser/resources/history/history.css
@@ -101,7 +101,8 @@ body:not(.uber-frame) {
   cursor: pointer;
 }
 
-html[dir=rtl] .entry-box {
+html[dir=rtl] .entry-box,
+html[dir=rtl] .site-domain-wrapper {
   float: right; /* To make the box shrink to fit its content. */
 }
 
@@ -123,6 +124,10 @@ html[dir=rtl] .entry-box {
   padding: 0;
 }
 
+html[dir='rtl'] .site-results {
+  clear: right;

[Patrick Dubroy, 2013/01/30 19:23:04]

Perhaps just use "clear: both" for simplicity?

[Sergiu, 2013/02/05 18:21:23]

Done.

+}
+
 h2.timeframe {
   font-size: 1.5em;
 }
@@ -150,7 +155,15 @@ h2.timeframe {
   display: none;
 }
 
+
+html[dir='rtl'] .number-visits {
+  direction: rtl;
+  unicode-bidi: embed;
+}
+
 .number-visits {
+  /* TODO(sergiu): make sure this works on rtl properly */

[Patrick Dubroy, 2013/01/30 19:23:04]

You should remove this TODO before landing...you are going to test this before
landing, right?

[Sergiu, 2013/01/30 21:12:43]

Well, it works in the current version, but I'm not sure about one thing, is
there any function that transforms numbers to locale specific versions? I
imagine that numbers are represented differently in some languages. Also the
parentheses seem like a pretty big complication from that point of view, I'm
just tempted to switch to something like "www.google.com - 5 visits" instead of
"www.google.com (5)"

[Patrick Dubroy, 2013/02/02 00:36:24]

I think arabic numerals are understood in most locales, and I think there are
many places in Chrome where we display numbers without localizing them, so I
think it's ok.

[Sergiu, 2013/02/05 18:21:23]

I've tested it in Arabic now as well and there's a single problem: the
parentheses mess things up. They trigger the engine to think that the construct
is always in LTR, which makes using things like -webkit-margin-end impossible.
I've used margins and dir='rtl' in the end.

+  -webkit-margin-start: 0.3em;
   color: rgb(151, 156, 160);
 }
 
@@ -178,7 +191,8 @@ h2.timeframe {
   border-color: rgb(48, 57, 66);
 }
 
-html[dir='rtl'] .entry .title {
+html[dir='rtl'] .entry .title,
+html[dir='rtl'] .site-domain {
   /* Put the favicon on the right. */
   background-position-x: right;
 }
@@ -249,7 +263,7 @@ html[dir='rtl'] .entry .title {
 
 .site-domain-arrow {
   -webkit-transition: -webkit-transform 300ms linear;
-  color: #8F8F8F;
+  color: rgb(143, 143, 143);
   height: 21px;
   margin-right: 2px;
   text-align: center;
@@ -264,6 +278,14 @@ html[dir='rtl'] .entry .title {
   -webkit-transform: rotate(90deg);
 }
 
+html[dir='rtl'] .site-domain-arrow {
+  -webkit-transform: scaleX(-1);

[Patrick Dubroy, 2013/01/30 19:23:04]

Maybe just do this with rotate() too? Might be a bit simpler that way.

[Sergiu, 2013/02/05 18:21:23]

Done.

+}
+
+html[dir='rtl'] .site-domain-arrow.expand {
+  -webkit-transform: scaleX(-1) rotate(90deg);
+}
+
 .entry .starred {
   -webkit-margin-start: 4px;
   background: url('../../../../ui/webui/resources/images/star_small.png') no-repeat;