Don't overwrite the refresh_token fetched by the policy_oauth_fetcher.

Don't overwrite the refresh_token fetched by the policy_oauth_fetcher.

If the policy_oauth_fetcher has already fetched a valid refresh_token then don't replace with the refresh_token from the TokenService. The TokenService is always empty during the first login of managed users, and its refresh_token is always empty on those cases.

BUG=170725

[Joao da Silva, 2013-01-23 16:21:54]

@Zel: please review

@Nikita: please make an owner review

I've manually triggered the bug and verified this fix. The issue is that on the
first sign-in the TokenService is empty, and doesn't have a refresh_token when
it issues NOTIFICATION_TOKEN_LOADING_FINISHED. The restore_from_auth_cookies_
flag is set to false when the refresh_token was already fetched by the
oauth2_policy_fetcher_.

[Nikita (slow), 2013-01-23 16:29:40]

Zel's review would be enough. I'll let him review this code.

[zel, 2013-01-23 16:43:57]

lgtm

[zel, 2013-01-23 16:44:50]

lgtm

https://codereview.chromium.org/12039044/diff/1/chrome/browser/chromeos/login...
File chrome/browser/chromeos/login/oauth2_login_manager.cc (right):

https://codereview.chromium.org/12039044/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/oauth2_login_manager.cc:156: // TODO(zelidrag):
Figure out why just getting GaiaConstants::kGaiaService
nit: please remove this comment while you are here... GAIA token is per-session,
that's why we can't really cache it

[Joao da Silva, 2013-01-23 16:50:37]

Thanks for the review!

https://codereview.chromium.org/12039044/diff/1/chrome/browser/chromeos/login...
File chrome/browser/chromeos/login/oauth2_login_manager.cc (right):

https://codereview.chromium.org/12039044/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/oauth2_login_manager.cc:156: // TODO(zelidrag):
Figure out why just getting GaiaConstants::kGaiaService
On 2013/01/23 16:44:50, zel wrote:
> nit: please remove this comment while you are here... GAIA token is
per-session,
> that's why we can't really cache it 

Done.

[commit-bot: I haz the power, 2013-01-23 16:50:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/12039044/6001