Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 12039037: Added a workaround for Windows compilation problems related to V8EXPORT. (Closed)

Created:
7 years, 11 months ago by Sven Panne
Modified:
7 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Added a workaround for Windows compilation problems related to V8EXPORT. The underlying problem is a bit unclear, but at least this CL makes VS happy. BUG=v8:2507 Committed: http://code.google.com/p/v8/source/detail?r=13470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
7 years, 11 months ago (2013-01-23 10:51:50 UTC) #1
Jakob Kummerow
7 years, 11 months ago (2013-01-23 11:42:34 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698