Add support for content shell builder and extra layout tests parameters

build/android/buildbot/bb_device_steps.py

Index: build/android/buildbot/bb_device_steps.py
diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py
index d512a855e8b229b5cf4fdfc88c3ab2be850bc956..e0398905a8f11a3b1aa9c1996a909a85d6720253 100755
--- a/build/android/buildbot/bb_device_steps.py
+++ b/build/android/buildbot/bb_device_steps.py
@@ -187,23 +187,32 @@ def RunWebkitLint(target):
 def RunWebkitLayoutTests(options):
   """Run layout tests on an actual device."""
   buildbot_report.PrintNamedStep('webkit_tests')
-  RunCmd(['webkit/tools/layout_tests/run_webkit_tests.py',
-          '--no-show-results',
-          '--no-new-test-results',
-          '--full-results-html',
-          '--clobber-old-results',
-          '--exit-after-n-failures', '5000',
-          '--exit-after-n-crashes-or-timeouts', '100',
-          '--debug-rwt-logging',
-          '--results-directory', '..layout-test-results',
-          '--target', options.target,
-          '--builder-name', options.build_properties.get('buildername', ''),
-          '--build-number', options.build_properties.get('buildnumber', ''),
-          '--master-name', options.build_properties.get('mastername', ''),
-          '--build-name', options.build_properties.get('buildername', ''),
-          '--platform=chromium-android',
-          '--test-results-server',
-          options.factory_properties.get('test_results_server', '')])
+  cmd_args = [
+        '--no-show-results',
+        '--no-new-test-results',
+        '--full-results-html',
+        '--clobber-old-results',
+        '--exit-after-n-failures', '5000',
+        '--exit-after-n-crashes-or-timeouts', '100',
+        '--debug-rwt-logging',
+        '--results-directory', '..layout-test-results',
+        '--target', options.target,
+        '--builder-name', options.build_properties.get('buildername', ''),
+        '--build-number', options.build_properties.get('buildnumber', ''),
+        '--master-name', options.build_properties.get('mastername', ''),
+        '--build-name', options.build_properties.get('buildername', ''),
+        '--platform=chromium-android']
+
+  for flag in 'test_results_server', 'driver_name', 'additional_drt_flag':

[Isaac (away), 2013/01/23 11:26:50]

This loop seems weird.  Won't it append multiple --test-results-server args?

[jochen (gone - plz use gerrit), 2013/01/23 12:08:13]

uups, fixed

+    if options.factory_properties.has_key(flag):

[Isaac (away), 2013/01/23 11:26:50]

nit: factory_properties is a dict.  Is it sufficient to use 'if flag in
options.factory_props' ?

[jochen (gone - plz use gerrit), 2013/01/23 12:08:13]

Done.

+      cmd_args.extend(['--test-results-server',
+                       options.factory_properties.get(flag)])
+
+  for f in options.factory_properties.get('additional_expectations_files', []):

[Isaac (away), 2013/01/23 11:26:50]

DIdn't know json.loads (the factory_props parser) produced list objects, but if
it works it looks right.

[jochen (gone - plz use gerrit), 2013/01/23 12:08:13]

The code is the same in scripts/master/factory/chromium_commands.py

+    cmd_args.append('--additional-expectations-file')

[Isaac (away), 2013/01/23 11:26:50]

nit: use extend w/ both args.

[jochen (gone - plz use gerrit), 2013/01/23 12:08:13]

Done.

+    cmd_args.append(os.path.join(CHROME_SRC, *f))
+
+  RunCmd(['webkit/tools/layout_tests/run_webkit_tests.py'] + cmd_args)
 
 
 def MainTestWrapper(options):