Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Side by Side Diff: Source/core/frame/FrameView.h

Issue 1203903003: AXScrollbar should not be recreated right after removal (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 // On Mac WebKit1 the underlying NSScrollView just does the scrolling, but o n most other platforms 309 // On Mac WebKit1 the underlying NSScrollView just does the scrolling, but o n most other platforms
310 // we need this function in order to do the scroll ourselves. 310 // we need this function in order to do the scroll ourselves.
311 ScrollResult wheelEvent(const PlatformWheelEvent&); 311 ScrollResult wheelEvent(const PlatformWheelEvent&);
312 312
313 virtual bool shouldUseIntegerScrollOffset() const override; 313 virtual bool shouldUseIntegerScrollOffset() const override;
314 314
315 virtual bool isActive() const override; 315 virtual bool isActive() const override;
316 316
317 // Override scrollbar notifications to update the AXObject cache. 317 // Override scrollbar notifications to update the AXObject cache.
318 virtual void didAddScrollbar(Scrollbar*, ScrollbarOrientation) override; 318 virtual void didAddScrollbar(Scrollbar*, ScrollbarOrientation) override;
319 virtual void willRemoveScrollbar(Scrollbar*, ScrollbarOrientation) override;
320 319
321 // FIXME: This should probably be renamed as the 'inSubtreeLayout' parameter 320 // FIXME: This should probably be renamed as the 'inSubtreeLayout' parameter
322 // passed around the FrameView layout methods can be true while this returns 321 // passed around the FrameView layout methods can be true while this returns
323 // false. 322 // false.
324 bool isSubtreeLayout() const { return !m_layoutSubtreeRoots.isEmpty(); } 323 bool isSubtreeLayout() const { return !m_layoutSubtreeRoots.isEmpty(); }
325 324
326 // Sets the tickmarks for the FrameView, overriding the default behavior 325 // Sets the tickmarks for the FrameView, overriding the default behavior
327 // which is to display the tickmarks corresponding to find results. 326 // which is to display the tickmarks corresponding to find results.
328 // If |m_tickmarks| is empty, the default behavior is restored. 327 // If |m_tickmarks| is empty, the default behavior is restored.
329 void setTickmarks(const Vector<IntRect>& tickmarks) 328 void setTickmarks(const Vector<IntRect>& tickmarks)
(...skipping 538 matching lines...) Expand 10 before | Expand all | Expand 10 after
868 static const unsigned visualPixelThreshold = 32 * 32; 867 static const unsigned visualPixelThreshold = 32 * 32;
869 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold) 868 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
870 setIsVisuallyNonEmpty(); 869 setIsVisuallyNonEmpty();
871 } 870 }
872 871
873 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView()); 872 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView());
874 873
875 } // namespace blink 874 } // namespace blink
876 875
877 #endif // FrameView_h 876 #endif // FrameView_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698