Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(56)

Issue 1203903003: AXScrollbar should not be recreated right after removal (Closed)

Created:
4 years, 10 months ago by keishi
Modified:
4 years, 10 months ago
Reviewers:
haraken, dmazzoni
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix leaking AXScrollbar AXScrollbar was being recreated right after it has been removed, causing it to leak. Test will be added in https://codereview.chromium.org/1202263005/ BUG=502782 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197754

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M Source/core/frame/FrameView.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 1 3 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
keishi
4 years, 10 months ago (2015-06-24 11:38:39 UTC) #2
haraken
LGTM
4 years, 10 months ago (2015-06-24 11:51:02 UTC) #3
dmazzoni
lgtm
4 years, 10 months ago (2015-06-24 14:21:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203903003/1
4 years, 10 months ago (2015-06-24 14:21:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/48611)
4 years, 10 months ago (2015-06-24 14:31:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203903003/20001
4 years, 10 months ago (2015-06-24 15:08:48 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2015-06-24 16:15:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197754

Powered by Google App Engine
This is Rietveld 408576698