Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 12039022: Merge r139337 to M25. (Closed)

Created:
7 years, 11 months ago by tony
Modified:
7 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge r139337 to M25. REGRESSION(r136967): margin-top + overflow:hidden causes incorrect layout for internal floated elements https://bugs.webkit.org/show_bug.cgi?id=106374 Reviewed by David Hyatt. r136397 treated any self-collapsing block that had a clearance delta as though it was clearing a float, but blocks that avoid floats can get a clearance delta too. So just ensure there is clearance on the block when deciding whether we need to add the margin back in before placing the float. TBR=tony@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, --1 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +10 lines, -0 lines 0 comments Download
A + LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden-and-float-child.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden-and-float-child-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +16 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderBlockLineLayout.cpp View 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698