Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 1203893002: PartitionAlloc: make PartitionPurgeDiscardUnusedSystemPages discard more. (Closed)

Created:
4 years, 10 months ago by Chris Evans
Modified:
4 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, Mads Ager (chromium), oilpan-reviews, haraken, blink-reviews-wtf_chromium.org, kouhei+heap_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@discard
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

PartitionAlloc: make PartitionPurgeDiscardUnusedSystemPages discard more. I think this is the final source of easily discardable pages: truncate the number of slots in a slot span, if the trailing slot(s) are unused. BUG=501878 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197776

Patch Set 1 #

Total comments: 5

Patch Set 2 : Action review feedback. #

Total comments: 1

Patch Set 3 : Action review comments. #

Patch Set 4 : Compile fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -15 lines) Patch
M Source/wtf/PartitionAlloc.cpp View 1 2 3 6 chunks +65 lines, -15 lines 0 comments Download
M Source/wtf/PartitionAllocTest.cpp View 1 3 chunks +126 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Chris Evans
This is getting a bit complicated, but I think it's worth it because we've now ...
4 years, 10 months ago (2015-06-24 00:51:45 UTC) #2
haraken
Nice idea! https://codereview.chromium.org/1203893002/diff/1/Source/wtf/PartitionAlloc.cpp File Source/wtf/PartitionAlloc.cpp (right): https://codereview.chromium.org/1203893002/diff/1/Source/wtf/PartitionAlloc.cpp#newcode1092 Source/wtf/PartitionAlloc.cpp:1092: memset(slotUsage, 1, sizeof(slotUsage)); memset(slotUsage, 1, sizeof(numSlots)); might ...
4 years, 10 months ago (2015-06-24 01:10:16 UTC) #3
Chris Evans
On 2015/06/24 01:10:16, haraken wrote: > Nice idea! > > https://codereview.chromium.org/1203893002/diff/1/Source/wtf/PartitionAlloc.cpp > File Source/wtf/PartitionAlloc.cpp (right): ...
4 years, 10 months ago (2015-06-24 05:58:45 UTC) #4
haraken
LGTM https://codereview.chromium.org/1203893002/diff/20001/Source/wtf/PartitionAlloc.cpp File Source/wtf/PartitionAlloc.cpp (right): https://codereview.chromium.org/1203893002/diff/20001/Source/wtf/PartitionAlloc.cpp#newcode1156 Source/wtf/PartitionAlloc.cpp:1156: if (truncatedSlots && discard) { if (truncatedSlots && ...
4 years, 10 months ago (2015-06-24 13:53:07 UTC) #5
Chris Evans
On 2015/06/24 13:53:07, haraken wrote: > LGTM > > https://codereview.chromium.org/1203893002/diff/20001/Source/wtf/PartitionAlloc.cpp > File Source/wtf/PartitionAlloc.cpp (right): > ...
4 years, 10 months ago (2015-06-24 18:32:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203893002/40001
4 years, 10 months ago (2015-06-24 18:33:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/68173)
4 years, 10 months ago (2015-06-24 18:58:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203893002/60001
4 years, 10 months ago (2015-06-24 19:22:56 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2015-06-24 20:32:31 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197776

Powered by Google App Engine
This is Rietveld 408576698