Android webview fix gpu crashes after destroy

content/common/gpu/gpu_command_buffer_stub.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/hash.h"
 #include "base/shared_memory.h"
@@ skipping 408 matching lines @@
     DCHECK(context->GetHandle());
     context = new gpu::GLContextVirtual(channel_->share_group(),
                                         context,
                                         decoder_->AsWeakPtr());
     if (!context->Initialize(surface_, gpu_preference_)) {
       // TODO(sievers): The real context created above for the default
       // offscreen surface might not be compatible with this surface.
       // Need to adjust at least GLX to be able to create the initial context
       // with a config that is compatible with onscreen and offscreen surfaces.
       context = NULL;
-      LOG(FATAL) << "Failed to initialize virtual GL context.";
+
+      // Ensure the decoder is not destroyed if it is not initialized.
+      decoder_.reset();
+
+      DLOG(ERROR) << "Failed to initialize virtual GL context.";
+      OnInitializeFailed(reply_message);
+      return;

[boliu, 2013/01/26 01:18:00]

Daniel...would this be better? I can't get it to fall into line 404...but I
copied the failure code from there...

[no sievers, 2013/01/28 19:46:15]

I'm surprised the failure here did not go away with holding the extra reference
on the ANativeWindow.

But properly failing here is good. I'd say LOG() instead of DLOG().

     } else {
       LOG(INFO) << "Created virtual GL context.";
     }
   }
   if (!context) {
     context = gfx::GLContext::CreateGLContext(
         channel_->share_group(),
         surface_.get(),
         gpu_preference_);
   }
@@ skipping 441 matching lines @@
     if (surface_ && MakeCurrent())
       surface_->SetFrontbufferAllocation(
           allocation.browser_allocation.suggest_have_frontbuffer);
   }
 
   last_memory_allocation_valid_ = true;
   last_memory_allocation_ = allocation;
 }
 
 }  // namespace content