Android webview fix gpu crashes after destroy

content/common/gpu/gpu_command_buffer_stub.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/hash.h"
 #include "base/shared_memory.h"
@@ skipping 408 matching lines @@
     DCHECK(context->GetHandle());
     context = new gpu::GLContextVirtual(channel_->share_group(),
                                         context,
                                         decoder_->AsWeakPtr());
     if (!context->Initialize(surface_, gpu_preference_)) {
       // TODO(sievers): The real context created above for the default
       // offscreen surface might not be compatible with this surface.
       // Need to adjust at least GLX to be able to create the initial context
       // with a config that is compatible with onscreen and offscreen surfaces.
       context = NULL;
-      LOG(FATAL) << "Failed to initialize virtual GL context.";
+      LOG(ERROR) << "Failed to initialize virtual GL context.";

[no sievers, 2013/01/25 20:24:41]

I don't really like removing the LOG(FATAL). I think we want to make sure that
on a platform that uses virtual contexts, it always works to create a virtual
context, which basically comes down to being able to make different surfaces
current with the same context (there's a known issue on Linux to make this work
at least).
It's scary to allow a mix of contexts, where we sometimes fail to share a real
context. We then end up not knowing what we are really running and that will
make it hard to deal with share-group related bugs.

Is this change needed if we correctly fail surface creation for which we should
bail out above in line 404? Do you know why this would fail here?

[boliu, 2013/01/25 21:27:02]

I didn't understand much of this, but sounds like this is the wrong fix. So
sounds like it should fall into line 404? I'll see what I can do. And I'll post
the stack trace for this one to the bug.

     } else {
       LOG(INFO) << "Created virtual GL context.";
     }
   }
   if (!context) {
     context = gfx::GLContext::CreateGLContext(
         channel_->share_group(),
         surface_.get(),
         gpu_preference_);
   }
@@ skipping 441 matching lines @@
     if (surface_ && MakeCurrent())
       surface_->SetFrontbufferAllocation(
           allocation.browser_allocation.suggest_have_frontbuffer);
   }
 
   last_memory_allocation_valid_ = true;
   last_memory_allocation_ = allocation;
 }
 
 }  // namespace content