Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: runtime/vm/compiler.cc

Issue 12038013: Reland r17365. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: replace enter with EnterFrame Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/disassembler_x64.cc » ('j') | runtime/vm/flow_graph_optimizer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc
index c5b865b4b5e539862b979143bb8ace7b235e642d..5f0a4161cf61c829fe042a64ce4d9f2511b09661 100644
--- a/runtime/vm/compiler.cc
+++ b/runtime/vm/compiler.cc
@@ -211,19 +211,21 @@ static bool CompileParsedFunctionHelper(const ParsedFunction& parsed_function,
// Do optimizations that depend on the propagated type information.
optimizer.Canonicalize();
- // Unbox doubles.
flow_graph->ComputeUseLists();
- optimizer.SelectRepresentations();
- if (FLAG_constant_propagation ||
- FLAG_common_subexpression_elimination) {
- flow_graph->ComputeUseLists();
- }
if (FLAG_constant_propagation) {
ConstantPropagator::Optimize(flow_graph);
// A canonicalization pass to remove e.g. smi checks on smi constants.
optimizer.Canonicalize();
}
+
+ // Unbox doubles. Performed after constant propagation to minimize
+ // interference from phis merging double values and tagged
+ // values comming from dead paths.
+ flow_graph->ComputeUseLists();
+ optimizer.SelectRepresentations();
+ flow_graph->ComputeUseLists();
+
if (FLAG_common_subexpression_elimination) {
if (DominatorBasedCSE::Optimize(flow_graph)) {
// Do another round of CSE to take secondary effects into account:
« no previous file with comments | « no previous file | runtime/vm/disassembler_x64.cc » ('j') | runtime/vm/flow_graph_optimizer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698