REGRESSION(r175642) Caused webkit unit tests failures

REGRESSION(r175642) Caused webkit unit tests failures

Chromium revision r175642 broke the webkit unit tests at webkit.org
http://wkb.ug/106631 because GetWebKitRootDir() returns a file path
that contains a relative "../.." component on some webkit bots.

Make webkit_support::GetWebKitRootDir() return an absolute path.

TEST=webkit unit tests pass
BUG=http://wkb.ug/106631

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177931

[tkent, 2013-01-21 02:03:55]

LGTM

[Nico, 2013-01-21 03:23:00]

https://codereview.chromium.org/12038003/diff/1/webkit/support/webkit_support.cc
File webkit/support/webkit_support.cc (right):

https://codereview.chromium.org/12038003/diff/1/webkit/support/webkit_support...
webkit/support/webkit_support.cc:471: CHECK(file_util::AbsolutePath(&path));
Shouldn't this be done in GetWebKitRootDirFilePath(), so that that does the
right thing for other callers too?

[Noel Gordon, 2013-01-21 03:31:08]

Are callers of GetWebKitRootDirFilePath() broken?

[commit-bot: I haz the power, 2013-01-21 03:41:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noel@chromium.org/12038003/1

[Nico, 2013-01-21 03:42:38]

On 2013/01/21 03:31:08, noel chromium wrote:
> Are callers of GetWebKitRootDirFilePath() broken?

It looks like GetWebKitRootDirFilePath() can return a path with ..s in it, and
those apparently don't work. So I'd assume that all callers are broken unless
this is fixed in GetWebKitRootDirFilePath()?

[Noel Gordon, 2013-01-21 03:42:52]

And regardless, this patch is about webkit unit tests failures only.

[Nico, 2013-01-21 03:43:40]

On 2013/01/21 03:42:52, noel chromium wrote:
> And regardless, this patch is about webkit unit tests failures only.

Right, but moving this one line somewhere else in this file would fix it for
everyone.

*shrug*

[Noel Gordon, 2013-01-21 03:57:21]

Separate bug really.  There are lots of users via a webkit_support helper
RewriteLayoutTestsURL()

    GetWebKitRootDirFilePath().Append(FILE_PATH_LITERAL("LayoutTests/"));

http://code.google.com/p/chromium/source/search?q=RewriteLayoutTestsURL

The seem to be previleged users (content shell, DRT, test shell,. etc), but
hmmmmmm, is this why the webkit bots have been having lots of trouble uploading
their webkit layout test results recently?

[Noel Gordon, 2013-01-21 04:00:57]

http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29?numbu...
 should some uploads are getting through.

[Noel Gordon, 2013-01-21 04:01:25]

s/shows/should/

[commit-bot: I haz the power, 2013-01-21 08:26:53]

Retried try job too often on win_rel for step(s) sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Noel Gordon, 2013-01-21 11:03:18]

Once more with feeling.

[commit-bot: I haz the power, 2013-01-21 11:03:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noel@chromium.org/12038003/1

[commit-bot: I haz the power, 2013-01-21 15:52:41]

Change committed as 177931