Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1203753002: Improve manage.py to automate CL creation further. (Closed)

Created:
5 years, 6 months ago by M-A Ruel
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Nico
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@7_components_browsertests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve manage.py to automate CL creation further. It's tedious to write CL description manually. Make manage.py make the CL description for me. R=dpranke@chromium.org BUG=98637 Committed: https://crrev.com/611a53e15beeda82fe4f00b04d8dfba33043e356 Cr-Commit-Position: refs/heads/master@{#335765}

Patch Set 1 #

Total comments: 3

Patch Set 2 : shorten #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -8 lines) Patch
M testing/buildbot/manage.py View 1 6 chunks +32 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
M-A Ruel
This permits me to create CLs like https://codereview.chromium.org/1200263002 in record time. This also makes the ...
5 years, 6 months ago (2015-06-23 18:58:30 UTC) #1
Dirk Pranke
lgtm https://codereview.chromium.org/1203753002/diff/1/testing/buildbot/manage.py File testing/buildbot/manage.py (right): https://codereview.chromium.org/1203753002/diff/1/testing/buildbot/manage.py#newcode197 testing/buildbot/manage.py:197: data['count_run_on_swarming']) this formatting is a bit odd; why ...
5 years, 6 months ago (2015-06-23 19:24:39 UTC) #2
Dirk Pranke
https://codereview.chromium.org/1203753002/diff/1/testing/buildbot/manage.py File testing/buildbot/manage.py (right): https://codereview.chromium.org/1203753002/diff/1/testing/buildbot/manage.py#newcode196 testing/buildbot/manage.py:196: '%d configs used to already run on Swarming' % ...
5 years, 6 months ago (2015-06-23 19:25:41 UTC) #3
M-A Ruel
https://codereview.chromium.org/1203753002/diff/1/testing/buildbot/manage.py File testing/buildbot/manage.py (right): https://codereview.chromium.org/1203753002/diff/1/testing/buildbot/manage.py#newcode196 testing/buildbot/manage.py:196: '%d configs used to already run on Swarming' % ...
5 years, 6 months ago (2015-06-23 19:29:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203753002/20001
5 years, 6 months ago (2015-06-23 19:32:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/37026)
5 years, 6 months ago (2015-06-23 20:55:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203753002/20001
5 years, 6 months ago (2015-06-23 20:58:07 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-23 22:10:03 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 22:11:02 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/611a53e15beeda82fe4f00b04d8dfba33043e356
Cr-Commit-Position: refs/heads/master@{#335765}

Powered by Google App Engine
This is Rietveld 408576698