Include glyph overflows caused by negative spacing into visual overflow

Include glyph overflows caused by negative spacing into visual overflow

BTW Modified the test to reproduce the bug without strict culling.

BUG=496317
TEST=fast/text/international/rtl-negative-letter-spacing.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197684

[Xianzhu, 2015-06-23 20:36:57]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org, eae@chromium.org

[Xianzhu, 2015-06-23 22:24:52]

Ptal.

[eae, 2015-06-23 22:28:54]

LGTM w/nit

https://codereview.chromium.org/1203743002/diff/20001/Source/core/layout/Layo...
File Source/core/layout/LayoutBlockFlowLine.cpp (right):

https://codereview.chromium.org/1203743002/diff/20001/Source/core/layout/Layo...
Source/core/layout/LayoutBlockFlowLine.cpp:435: if (measuredWidth < 0) {
This could use a comment.

[chrishtr, 2015-06-23 22:31:04]

I'll defer to Emil's review, he is more versed in this code.

[Xianzhu, 2015-06-23 22:43:05]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2015-06-23 22:43:05]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1203743002/#ps40001
(title: "Add comments about negative word-spacing/letter-spacing")

[Xianzhu, 2015-06-23 22:43:33]

https://codereview.chromium.org/1203743002/diff/20001/Source/core/layout/Layo...
File Source/core/layout/LayoutBlockFlowLine.cpp (right):

https://codereview.chromium.org/1203743002/diff/20001/Source/core/layout/Layo...
Source/core/layout/LayoutBlockFlowLine.cpp:435: if (measuredWidth < 0) {
On 2015/06/23 22:28:54, eae wrote:
> This could use a comment.

Done.

[commit-bot: I haz the power, 2015-06-23 22:43:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1203743002/40001

[commit-bot: I haz the power, 2015-06-24 00:05:02]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197684