Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1203733002: Avoid built-ins in `Date.prototype.toISOString` (Closed)

Created:
5 years, 6 months ago by mathias
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid built-ins in `Date.prototype.toISOString` TEST=mjsunit/date BUG=v8:4226 LOG=N Committed: https://crrev.com/57306b59e8f19eca89ef7d4773e132ac016651a0 Cr-Commit-Position: refs/heads/master@{#29240}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M src/date.js View 2 chunks +8 lines, -8 lines 0 comments Download
M test/mjsunit/date.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mathias
5 years, 6 months ago (2015-06-23 15:53:20 UTC) #3
arv (Not doing code reviews)
LGTM
5 years, 6 months ago (2015-06-23 15:56:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203733002/20001
5 years, 6 months ago (2015-06-23 18:03:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 6 months ago (2015-06-23 18:43:03 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 18:43:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57306b59e8f19eca89ef7d4773e132ac016651a0
Cr-Commit-Position: refs/heads/master@{#29240}

Powered by Google App Engine
This is Rietveld 408576698